Use TYPE_CHECKING in optuna/pruners/_nop.py#6297
Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom Oct 14, 2025
Merged
Conversation
Move Study and FrozenTrial imports into TYPE_CHECKING block to avoid potential circular import issues. Keep 'import optuna' at runtime as it's used in docstring examples. Fixes optuna#6029
Contributor
Author
|
There is a failure with the run : I checked the logs, This appears to be a transient network issue unrelated to my changes. Could you please re-run the CI checks? Thanks! |
TYPE_CHECKING in optuna/pruners/_nop.py
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
StudyandFrozenTrialimports intoTYPE_CHECKINGblock to avoid potential circular import issues.Changes
from typing import TYPE_CHECKINGStudyandFrozenTrialimports intoif TYPE_CHECKING:block"optuna.study.Study"to"Study"optuna.trial.FrozenTrial. toFrozenTrialimport optunawith# noqa: F401, TC001as it's used in docstring examplesVerification
flake8and confirmed no errorsblackandisortRelated to:
TYPE_CHECKINGif necessary #6029