Modify TYPE_CHECKING in _brute_force.py#6259
Merged
nabenabe0928 merged 1 commit intooptuna:masterfrom Aug 27, 2025
Merged
Conversation
TYPE_CHECKING in _brute_force.py
397f341 to
57fade1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6259 +/- ##
==========================================
- Coverage 89.26% 89.24% -0.03%
==========================================
Files 208 208
Lines 13820 13821 +1
==========================================
- Hits 12336 12334 -2
- Misses 1484 1487 +3 ☔ View full report in Codecov by Sentry. |
Contributor
|
LGTM! |
nabenabe0928
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This issue partially addresses the following issue.
TYPE_CHECKINGif necessary #6029Description of the changes