test(test_brute_force): Fix fragile test_parallel_optimize_with_sleep#6241
Merged
y0z merged 2 commits intooptuna:masterfrom Aug 20, 2025
Merged
test(test_brute_force): Fix fragile test_parallel_optimize_with_sleep#6241y0z merged 2 commits intooptuna:masterfrom
y0z merged 2 commits intooptuna:masterfrom
Conversation
6816aac to
3ccf502
Compare
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
LGTM!
I left some minor comments:)
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
approved these changes
Aug 19, 2025
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for applying the suggestions, I approved this PR:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6206.
Related to #6217, #6209.
test_parallel_optimize_with_sleepis supposed to testavoid_premature_stop. Instead of using sleep to test this behavior, which is potentially fragile, I used the ask-and-tell API instead.Description of the changes
test_avoid_premature_stop/test_not_avoid_premature_stopinstead oftest_parallel_optimize_with_sleep.