Closed
Conversation
bd63b09 to
aca6bdf
Compare
fragile test_brute_force.py
fragile test_brute_force.pytest_brute_force.py
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
| limit = 200 # avoid infinite after 100 seconds | ||
|
|
||
| # Guarantee that the trial with x=0 is completed before the trial with x=1. | ||
| while len(study.get_trials(states=[optuna.trial.TrialState.COMPLETE])) < 2: |
Contributor
There was a problem hiding this comment.
What about using this directly?
I think checking study._stop_flag is more direct and sure.
Suggested change
| while len(study.get_trials(states=[optuna.trial.TrialState.COMPLETE])) < 2: | |
| while not study._stop_flag: |
Member
Author
There was a problem hiding this comment.
I think study._stop_flag indicates that the optimization loop has finished.
But in this case, I want to wait only until the first two trials have completed (while one trial remains RUNNING).
So I don’t think study._stop_flag would become True here.
This was referenced Jul 24, 2025
Contributor
|
This pull request has not seen any recent activity. |
Member
Author
|
I will create the new PR for this test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #6206.
Description of the changes
Under the high-load environment (like ci with xdist), the
sleep(1)is not enough to guarantee the suggestion order. So I fixed it to guarantee the suggestion order.