Use TYPE_CHECKING in optuna/_gp/optim_mixed.py to avoid circular imports#6205
Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom Jul 20, 2025
Merged
Conversation
optuna/_gp/optim_mixed.py
Outdated
Comment on lines
+7
to
+8
| if TYPE_CHECKING: | ||
| from optuna._gp.acqf import BaseAcquisitionFunc |
Contributor
There was a problem hiding this comment.
Could you merge the TYPE_CHECKING section?
It is already defined below.
Contributor
Author
|
issue has been fixed |
nabenabe0928
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, a module (optuna._gp.acqf.BaseAcquisitionFunc) is imported unconditionally in optuna/_gp/opim_mixed.py, which can trigger circular‐import errors at runtime. By moving these imports into a if TYPE_CHECKING: block, we ensure they’re only used for static type hints and never executed during normal imports. This improves import safety and prevents spurious CI failures or runtime import errors when using the GP acquisition‐function code.
Description of the changes
python3 -m flake8 optuna/_gp/opim_mixed.py
emits no TC001 warnings
Fixed #6029