Update TYPE_CHECKING for optuna/_gp/gp.py#6090
Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom May 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Could you remove the double quotations from these lines?
Lines 19 to 22 in 3aef474
Contributor
Author
There was a problem hiding this comment.
I see there's a test failing. I'll look into it tomorrow.
Contributor
There was a problem hiding this comment.
No worries, the fail doesn't relate to your change!
I reran the CI:)
nabenabe0928
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR relates to:
TYPE_CHECKINGif necessary #6029Description of the changes
TYPE_CHECKINGforoptuna/_gp/gp.py