Adapt TYPE_CHECKING of samplers/_gp/sampler.py#6059
Merged
nabenabe0928 merged 1 commit intooptuna:masterfrom May 7, 2025
Merged
Conversation
Member
|
@gen740 @kAIto47802 Could you review this PR? |
Contributor
Author
|
@y0z Could you review this PR? |
kAIto47802
approved these changes
May 2, 2025
Collaborator
There was a problem hiding this comment.
Thank you for the PR!
As for the type annotations, the return type -> None is not needed if at least one argument is annotated, since then the function is considered as "typed."1
However, this is orthogonal to the motivation behind the issue:
Therefore, it's also acceptable to leave this change out of the current PR.
Footnotes
Contributor
Author
|
@kAIto47802 But your remark is also important:) |
y0z
approved these changes
May 7, 2025
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR relates to:
TYPE_CHECKINGif necessary #6029Description of the changes
TYPE_CHECKINGas mentioned in the PR title