Skip to content

Update Type-Checking for optuna/_gp/gp.py#6053

Merged
c-bata merged 1 commit intooptuna:masterfrom
ParagEkbote:Fix-Type-Checking-for-GP
Apr 21, 2025
Merged

Update Type-Checking for optuna/_gp/gp.py#6053
c-bata merged 1 commit intooptuna:masterfrom
ParagEkbote:Fix-Type-Checking-for-GP

Conversation

@ParagEkbote
Copy link
Copy Markdown
Contributor

Motivation

Refs #6029

As described in the issue, I have updated type checking for the file and flake8 does not show any warnings.

Could you please review?

cc: @nabenabe0928

Description of the changes

Updated Type-Checking for optuna/_gp/gp.py

@c-bata
Copy link
Copy Markdown
Member

c-bata commented Apr 17, 2025

@ParagEkbote Thank you for your continuous contribution!

You've been doing an excellent job tackling "good first" issues (#6029). Given your skills and familiarity with the codebase, we’d love to see you take on more challenging issues like below and leave beginner-friendly ones for new contributors!
https://github.com/optuna/optuna/issues?q=is%3Aissue%20state%3Aopen%20label%3Acontribution-welcome

@c-bata c-bata self-assigned this Apr 17, 2025
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label Apr 21, 2025
@c-bata c-bata added this to the v4.4.0 milestone Apr 21, 2025
@c-bata c-bata merged commit 430d450 into optuna:master Apr 21, 2025
15 checks passed
@ParagEkbote ParagEkbote deleted the Fix-Type-Checking-for-GP branch April 21, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants