Skip to content

Update Type-Checking for optuna/_convert_positional_args.py#6050

Merged
c-bata merged 1 commit intooptuna:masterfrom
ParagEkbote:Fix-Type-Checking-For-Convert-Positional-Args
Apr 21, 2025
Merged

Update Type-Checking for optuna/_convert_positional_args.py#6050
c-bata merged 1 commit intooptuna:masterfrom
ParagEkbote:Fix-Type-Checking-For-Convert-Positional-Args

Conversation

@ParagEkbote
Copy link
Copy Markdown
Contributor

Motivation

Refs #6029

As described in the issue, I have updated type checking for the file and flake8 does not show any warnings.

Could you please review?

cc: @nabenabe0928

Description of the changes

Updated type checking for optuna/_convert_positional_args.py

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Apr 16, 2025
@nabenabe0928 nabenabe0928 added this to the v4.4.0 milestone Apr 16, 2025
@c-bata c-bata self-assigned this Apr 17, 2025
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata merged commit 2965491 into optuna:master Apr 21, 2025
15 checks passed
@ParagEkbote ParagEkbote deleted the Fix-Type-Checking-For-Convert-Positional-Args branch April 21, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants