Migrate LightGBM integration#5249
Merged
HideakiImamura merged 22 commits intooptuna:masterfrom Feb 15, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5249 +/- ##
==========================================
- Coverage 89.83% 89.31% -0.52%
==========================================
Files 213 206 -7
Lines 13707 13020 -687
==========================================
- Hits 12313 11629 -684
+ Misses 1394 1391 -3 ☔ View full report in Codecov by Sentry. |
dc15fe5 to
9956f66
Compare
nabenabe0928
suggested changes
Feb 14, 2024
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for the PR, I found a critical problem we need to address, please take a close look!
Member
|
@nabenabe0928 While you have already reviewed this PR, let me assign you as a reviewer. |
nabenabe0928
approved these changes
Feb 15, 2024
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have several comments. PTAL.
tutorial/10_key_features/003_efficient_optimization_algorithms.py
Outdated
Show resolved
Hide resolved
tutorial/10_key_features/003_efficient_optimization_algorithms.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Progress #4484.
Description of the changes