Conversation
# Conflicts: # README.md
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 68.34% 72.37% +4.03%
==========================================
Files 33 39 +6
Lines 2805 3345 +540
==========================================
+ Hits 1917 2421 +504
- Misses 888 924 +36 ☔ View full report in Codecov by Sentry. |
y0z
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
I leave some comments.
- Please use
optuna_integrationinstead ofoptuna.integrationand apply isort.
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
|
Please update the description of this PR (significantly, please add a link to optuna/optuna#4484).
This helps us track the progress of the integration migration. Following optuna/optuna#4484, as a member of the Optuna organization, I would create a counterpart to this PR, which would remove Optuna's LightGBM integration from the optuna/otpuna repository.
|
@y0z thank you for your review |
# Conflicts: # README.md # docs/source/reference/index.rst # optuna_integration/__init__.py # pyproject.toml
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for the PR! I suggested some minor changes!
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for your work! LGTM!
| params: dict = {"verbose": -1} | ||
| dataset = lgb.Dataset(np.zeros((10, 10))) | ||
|
|
||
| with mock.patch("optuna.integration._lightgbm_tuner.optimize.os.mkdir") as m: |
There was a problem hiding this comment.
@nabenabe0928 What about this one? Test passing it, is that correct?
| def objective(trial: optuna.trial.Trial, value: float) -> float: | ||
| trial.storage.set_trial_system_attr( | ||
| trial._trial_id, | ||
| optuna.integration._lightgbm_tuner.optimize._STEP_NAME_KEY, |
There was a problem hiding this comment.
@nabenabe0928 What about this one? Test passing it, is that correct?
|
@nabenabe0928 thank you for your review |
Motivation
Progress Isolation of optuna integration modules..
Description of the changes
Add LightBGM integration and its tests.