Skip to content

Remove XGBoost Integration#5238

Closed
nabenabe0928 wants to merge 3 commits intooptuna:masterfrom
nabenabe0928:code-fix/remove-xgboost-integration
Closed

Remove XGBoost Integration#5238
nabenabe0928 wants to merge 3 commits intooptuna:masterfrom
nabenabe0928:code-fix/remove-xgboost-integration

Conversation

@nabenabe0928
Copy link
Copy Markdown
Contributor

Motivation

Salvage #5218.

Description of the changes

I cherry-picked https://github.com/optuna/optuna/tree/a9b7718ddc947d66f39e7a9f61f92f6d20c19d26.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (83d6b1a) 90.04% compared to head (a40905f) 90.16%.

Files Patch % Lines
optuna/integration/xgboost.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5238      +/-   ##
==========================================
+ Coverage   90.04%   90.16%   +0.11%     
==========================================
  Files         213      213              
  Lines       14365    14305      -60     
==========================================
- Hits        12935    12898      -37     
+ Misses       1430     1407      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buruzaemon
Copy link
Copy Markdown
Contributor

Thanks very much @nabenabe0928! I enjoy using optuna and I was very happy to contribute a bit to the project.

@nabenabe0928
Copy link
Copy Markdown
Contributor Author

@buruzaemon
@y0z cherry-picked your previous PRs, so we will use the branch instead!
Please check #5239

@nabenabe0928 nabenabe0928 deleted the code-fix/remove-xgboost-integration branch February 19, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants