Skip to content

Remove XGBoost Integration#5239

Merged
contramundum53 merged 8 commits intooptuna:masterfrom
y0z:feature/buruzaemon
Feb 9, 2024
Merged

Remove XGBoost Integration#5239
contramundum53 merged 8 commits intooptuna:masterfrom
y0z:feature/buruzaemon

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 9, 2024

Motivation

Description of the changes

@nabenabe0928
Copy link
Copy Markdown
Contributor

@y0z Could you remove xgboost from pyproject.toml?

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (11dca39) 89.76% compared to head (98a7789) 89.88%.

Files Patch % Lines
optuna/integration/xgboost.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
+ Coverage   89.76%   89.88%   +0.12%     
==========================================
  Files         213      213              
  Lines       14064    14004      -60     
==========================================
- Hits        12624    12587      -37     
+ Misses       1440     1417      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 removed their assignment Feb 9, 2024
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 merged commit 0d8e1be into optuna:master Feb 9, 2024
@y0z y0z deleted the feature/buruzaemon branch February 9, 2024 09:06
@y0z
Copy link
Copy Markdown
Member Author

y0z commented Feb 13, 2024

Done: #4484

@nabenabe0928 nabenabe0928 added the compatibility Change that breaks compatibility. label Feb 14, 2024
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants