Skip to content

Remove BoTorch integration#5230

Merged
nabenabe0928 merged 8 commits intooptuna:masterfrom
y0z:feature/migrate-botorch
Feb 7, 2024
Merged

Remove BoTorch integration#5230
nabenabe0928 merged 8 commits intooptuna:masterfrom
y0z:feature/migrate-botorch

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 7, 2024

Motivation

Progress #4484.
Remove the BoTorch integration for migration to optuna_integration.

Please merge optuna/optuna-integration#72 before merging this PR.

Description of the changes

  • Remove the BoTorch integration and the related tests from optuna.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 7, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (67fd378) 89.35% compared to head (574f6e3) 89.01%.
Report is 2 commits behind head on master.

Files Patch % Lines
optuna/integration/botorch.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5230      +/-   ##
==========================================
- Coverage   89.35%   89.01%   -0.35%     
==========================================
  Files         213      213              
  Lines       15234    14523     -711     
==========================================
- Hits        13613    12927     -686     
+ Misses       1621     1596      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53
Copy link
Copy Markdown
Member

@nabenabe0928 Could you review this PR?

@nabenabe0928
Copy link
Copy Markdown
Contributor

nabenabe0928 commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a TODO list.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Feb 7, 2024

@nabenabe0928 We include integrations in benchmarks, like PyCmaSampler

@nabenabe0928 nabenabe0928 removed their assignment Feb 7, 2024
@nabenabe0928
Copy link
Copy Markdown
Contributor

@y0z Sorry, docs include terminator, so we could not remove botorch from the doc section right now...

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit fc32e4b into optuna:master Feb 7, 2024
@not522 not522 added this to the v3.6.0 milestone Feb 8, 2024
@not522 not522 added the compatibility Change that breaks compatibility. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants