Skip to content

Migrate BoTorch integration#72

Merged
contramundum53 merged 7 commits intooptuna:mainfrom
y0z:feature/botorch
Feb 7, 2024
Merged

Migrate BoTorch integration#72
contramundum53 merged 7 commits intooptuna:mainfrom
y0z:feature/botorch

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 6, 2024

Motivation

Description of the changes

@y0z y0z changed the title Feature/botorch Migrate BoTorch integration Feb 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2734577) 58.03% compared to head (b185aa4) 65.09%.

Files Patch % Lines
optuna_integration/botorch.py 94.73% 19 Missing ⚠️
optuna_integration/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   58.03%   65.09%   +7.06%     
==========================================
  Files          24       25       +1     
  Lines        1506     1868     +362     
==========================================
+ Hits          874     1216     +342     
- Misses        632      652      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@contramundum53
Copy link
Copy Markdown
Member

@y0z The coverage says that BoTorchSampler is not covered by tests, although you seem to have added test_samplers.

@y0z
Copy link
Copy Markdown
Member Author

y0z commented Feb 7, 2024

I fixed the code and test coverage is now fine.

@contramundum53
Copy link
Copy Markdown
Member

Thank you, LGTM!

@contramundum53 contramundum53 merged commit 2fd5266 into optuna:main Feb 7, 2024
@y0z y0z deleted the feature/botorch branch February 7, 2024 07:41
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 8, 2024
@nabenabe0928 nabenabe0928 added the feature Change that does not break compatibility, but affects the public interfaces. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Change that does not break compatibility, but affects the public interfaces.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants