Skip to content

Remove dask integration#5222

Merged
contramundum53 merged 5 commits intooptuna:masterfrom
gen740:move-dask-integration
Feb 7, 2024
Merged

Remove dask integration#5222
contramundum53 merged 5 commits intooptuna:masterfrom
gen740:move-dask-integration

Conversation

@gen740
Copy link
Copy Markdown
Member

@gen740 gen740 commented Feb 2, 2024

Motivation

Progress #4484.

Description of the changes

Remove DastStorage from optuna.

@github-actions github-actions bot added optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.testing Related to the `optuna.testing` submodule. This is automatically labeled by github-actions. labels Feb 2, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (53d8554) 89.37% compared to head (8db17a2) 89.22%.

Files Patch % Lines
optuna/integration/dask.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5222      +/-   ##
==========================================
- Coverage   89.37%   89.22%   -0.16%     
==========================================
  Files         206      206              
  Lines       15097    14853     -244     
==========================================
- Hits        13493    13252     -241     
+ Misses       1604     1601       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Feb 5, 2024

@gen740 LGTM. Could you ping us when optuna/optuna-integration#67 is merged?

@contramundum53 contramundum53 self-assigned this Feb 6, 2024
contramundum53
contramundum53 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Feb 6, 2024 •
edited
Loading

The windows test failure seems unrelated.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Feb 6, 2024

@y0z Could you review this PR?

y0z
y0z approved these changes Feb 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@contramundum53 contramundum53 merged commit 67fd378 into optuna:master Feb 7, 2024
@y0z y0z removed their assignment Feb 7, 2024
@gen740 gen740 deleted the move-dask-integration branch February 7, 2024 10:21
@not522 not522 added this to the v3.6.0 milestone Feb 8, 2024
@not522 not522 added the compatibility Change that breaks compatibility. label Feb 8, 2024
@nabenabe0928 nabenabe0928 mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@contramundum53 contramundum53 contramundum53 approved these changes

@y0z y0z y0z approved these changes

Assignees

@contramundum53 contramundum53

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.testing Related to the `optuna.testing` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@gen740 @contramundum53 @y0z @not522