Skip to content

Move dask integration.#67

Merged
contramundum53 merged 5 commits intooptuna:mainfrom
gen740:move-dash-integration
Feb 6, 2024
Merged

Move dask integration.#67
contramundum53 merged 5 commits intooptuna:mainfrom
gen740:move-dash-integration

Conversation

@gen740
Copy link
Copy Markdown
Member

@gen740 gen740 commented Feb 2, 2024

Motivation

Progress optuna/optuna#4484

Description of the changes

Move DaskStorage into optuna-integration.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (f6f7ade) 35.95% compared to head (7b8d965) 45.17%.

Files Patch % Lines
optuna_integration/dask.py 79.39% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   35.95%   45.17%   +9.21%     
==========================================
  Files          21       22       +1     
  Lines         865     1098     +233     
==========================================
+ Hits          311      496     +185     
- Misses        554      602      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo and rename the title Move dash integration. #67 to Move dask integration. #67 for search convenience.

LGTM for the code.

Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53 contramundum53 changed the title Move dash integration. Move dask integration. Feb 6, 2024
@contramundum53 contramundum53 merged commit b9f6072 into optuna:main Feb 6, 2024
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 8, 2024
@nabenabe0928 nabenabe0928 added the feature Change that does not break compatibility, but affects the public interfaces. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Change that does not break compatibility, but affects the public interfaces.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants