Remove CatBoost integration for isolation.#5198
Merged
HideakiImamura merged 2 commits intooptuna:masterfrom Jan 26, 2024
Merged
Remove CatBoost integration for isolation.#5198HideakiImamura merged 2 commits intooptuna:masterfrom
HideakiImamura merged 2 commits intooptuna:masterfrom
Conversation
Member
Author
|
@nabenabe0928 Could you review this PR and the related PR (optuna/optuna-integration#61) ? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
- Coverage 89.40% 89.39% -0.01%
==========================================
Files 206 206
Lines 15133 15097 -36
==========================================
- Hits 13529 13496 -33
+ Misses 1604 1601 -3 ☔ View full report in Codecov by Sentry. |
Member
|
@nabenabe0928 Could you review this PR? |
nabenabe0928
suggested changes
Jan 24, 2024
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
I left one comment, but otherwise the PR looks good to me.
Member
Author
|
Thank you for your feedback. I applied your comment. PTAL. |
nabenabe0928
approved these changes
Jan 25, 2024
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for the changes, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Description of the changes
optuna_integration.catboostinstead ofoptuna.integration.catboostPlease merge the following PR before merging this PR.