Skip to content

Add CatBoost integration#61

Merged
nabenabe0928 merged 8 commits intooptuna:mainfrom
y0z:feature/catboost
Jan 29, 2024
Merged

Add CatBoost integration#61
nabenabe0928 merged 8 commits intooptuna:mainfrom
y0z:feature/catboost

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Jan 23, 2024

Motivation

Description of the changes

  • Add optuna/integration/catboost.py and its test from optuna/optuna to optuna-integration for isolation of the CatBoost integration

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7f4ee88) 33.37% compared to head (58a0953) 35.95%.

Files Patch % Lines
optuna_integration/catboost.py 92.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   33.37%   35.95%   +2.58%     
==========================================
  Files          20       21       +1     
  Lines         827      865      +38     
==========================================
+ Hits          276      311      +35     
- Misses        551      554       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

y0z and others added 4 commits January 25, 2024 11:23
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
@y0z
Copy link
Copy Markdown
Member Author

y0z commented Jan 25, 2024

Thank you for your feedback.
I checked and applied your suggestions.
Please confirm the changes.

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit 7aadf69 into optuna:main Jan 29, 2024
@y0z y0z deleted the feature/catboost branch January 30, 2024 01:30
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 8, 2024
@nabenabe0928 nabenabe0928 added the feature Change that does not break compatibility, but affects the public interfaces. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Change that does not break compatibility, but affects the public interfaces.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants