Fix mypy error about Chainer#4410
Merged
toshihikoyanase merged 2 commits intooptuna:masterfrom Feb 10, 2023
Merged
Conversation
Contributor
Author
toshihikoyanase
approved these changes
Feb 10, 2023
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your PR. LGTM.
Let me merge this PR since it only updates the code comments for mypy in the test file.
|
|
||
| if not _imports.is_successful(): | ||
| DatasetMixin = object # NOQA | ||
| DatasetMixin = object # type: ignore[assignment, misc] # NOQA |
Member
There was a problem hiding this comment.
[Note] This fix corresponds to the following errors in https://github.com/optuna/optuna/actions/runs/4139175958/jobs/7156458918:
tests/integration_tests/test_chainer.py:23: error: Cannot assign to a type [misc]
tests/integration_tests/test_chainer.py:23: error: Incompatible types in assignment (expression has type "Type[object]", variable has type "Type[DatasetMixin]") [assignment]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #4116
Description of the changes
Ignore mypy error which occurs at the 23rd line of
tests/integration_tests/test_chainer.py.Note that mypy error of the line was used to be ignored before PR #4276 but I removed
type: ignoreto reduce unused warnings. Mypy recognize this as error again from 1.0.0.