Fix mypy error abut Chainer in Checks (integration)#4276
Merged
c-bata merged 2 commits intooptuna:masterfrom Jan 16, 2023
Merged
Fix mypy error abut Chainer in Checks (integration)#4276c-bata merged 2 commits intooptuna:masterfrom
Chainer in Checks (integration)#4276c-bata merged 2 commits intooptuna:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4276 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 170 170
Lines 13261 13261
=======================================
Hits 11904 11904
Misses 1357 1357
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Chainer in Checks (integration)
Contributor
|
This pull request has not seen any recent activity. |
Member
|
@cross32768 Could you review this PR? |
HideakiImamura
approved these changes
Jan 5, 2023
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
LGTM! I confirmed that the Chainer integration does not occur any errors in Checks (integration). https://github.com/HideakiImamura/optuna/actions/runs/3844638959/jobs/6547923432
cross32768
approved these changes
Jan 5, 2023
Contributor
There was a problem hiding this comment.
LGTM! I confirmed that 8 mypy errors related to chariner are appeared in master branch as shown below, and this PR resolves all.
optuna/integration/chainer.py:10: error: Module "chainer.training.triggers" does not explicitly export attribute "IntervalTrigger" [attr-defined]
optuna/integration/chainer.py:11: error: Module "chainer.training.triggers" does not explicitly export attribute "ManualScheduleTrigger" [attr-defined]
tests/integration_tests/test_chainer.py:18: error: Module "chainer.dataset" does not explicitly export attribute "DatasetMixin" [attr-defined]
tests/integration_tests/test_chainer.py:47: error: "Module chainer.training.triggers" does not explicitly export attribute "IntervalTrigger" [attr-defined]
tests/integration_tests/test_chainer.py:51: error: "Module chainer.training.triggers" does not explicitly export attribute "IntervalTrigger" [attr-defined]
tests/integration_tests/test_chainer.py:55: error: "Module chainer.training.triggers" does not explicitly export attribute "ManualScheduleTrigger" [attr-defined]
tests/integration_tests/test_chainer.py:113: error: "Module chainer.training.triggers" does not explicitly export attribute "IntervalTrigger" [attr-defined]
tests/integration_tests/test_chainer.py:121: error: "Module chainer.training.triggers" does not explicitly export attribute "IntervalTrigger" [attr-defined]
Contributor
|
This pull request has not seen any recent activity. |
Contributor
Author
|
Thank you for your approval. |
Member
|
Let me merge this PR since there are already two approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solve scheduled Checks (Integration) failure
Description of the changes
Currently, scheduled Checks (Integration) fails die to mypy check with
--warn-unused-ignoresoption. This PR removes a part of the cause related toChainer.Although test for Checks (Integration) does't run when PR in opened, I confirmed this PR together with other "Fix mypy error" series reduces mypy error at CI on my fork.