Skip to content

Run test_pytorch_distributed.py again#4301

Merged
not522 merged 4 commits intooptuna:masterfrom
HideakiImamura:test-pytorch-distributed-again
Jan 13, 2023
Merged

Run test_pytorch_distributed.py again#4301
not522 merged 4 commits intooptuna:masterfrom
HideakiImamura:test-pytorch-distributed-again

Conversation

@HideakiImamura
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura commented Jan 4, 2023

Motivation

In #4150, I accidentally deleted the part that runs test_pytorch_distributed.py. As a result, recent changes have caused daily CI to fail. This PR will make sure to run test_pytorch_distributed.py again and also modify daily CI.

Description of the changes

  • Run test_pytorch_distributed.py again
  • Fix the test

@HideakiImamura
Copy link
Copy Markdown
Member Author

@not522 @gen740 Could you review this PR?

@nzw0301
Copy link
Copy Markdown
Member

nzw0301 commented Jan 4, 2023

I've deleted it according to #3983 😢 Thank you for your follow-up!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #4301 (2db4a4d) into master (7bb50ca) will increase coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
+ Coverage   89.75%   90.43%   +0.68%     
==========================================
  Files         170      172       +2     
  Lines       13265    13659     +394     
==========================================
+ Hits        11906    12353     +447     
+ Misses       1359     1306      -53     
Impacted Files Coverage Δ
optuna/_callbacks.py 97.29% <ø> (ø)
optuna/integration/_lightgbm_tuner/optimize.py 95.84% <ø> (ø)
optuna/integration/mlflow.py 98.91% <ø> (ø)
optuna/integration/sklearn.py 96.75% <ø> (ø)
optuna/integration/wandb.py 96.92% <ø> (ø)
optuna/logging.py 98.36% <ø> (ø)
optuna/samplers/_qmc.py 97.93% <ø> (ø)
optuna/storages/_base.py 79.81% <ø> (ø)
optuna/study/study.py 94.18% <ø> (ø)
optuna/visualization/_pareto_front.py 97.29% <ø> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@not522
Copy link
Copy Markdown
Member

not522 commented Jan 4, 2023

Could you add it for coverage.yml?

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura
Copy link
Copy Markdown
Member Author

@not522 Thanks for your review. PTAL.

HideakiImamura and others added 2 commits January 13, 2023 11:20
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM!

@not522 not522 merged commit 82324f1 into optuna:master Jan 13, 2023
@not522 not522 added the CI Continuous integration. label Jan 13, 2023
@not522 not522 added this to the v3.1.0 milestone Jan 13, 2023
@HideakiImamura HideakiImamura deleted the test-pytorch-distributed-again branch June 9, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants