Skip to content

Drop python 3.6 from integration CIs#3983

Merged
contramundum53 merged 1 commit intooptuna:masterfrom
nzw0301:drop-python3.6-from-integration-ci
Sep 27, 2022
Merged

Drop python 3.6 from integration CIs#3983
contramundum53 merged 1 commit intooptuna:masterfrom
nzw0301:drop-python3.6-from-integration-ci

Conversation

@nzw0301
Copy link
Copy Markdown
Member

@nzw0301 nzw0301 commented Sep 10, 2022

Motivation

#3021 (comment): remove Python 3.6 tests from the CI of the integrations. Note that we keep using python 3.6 to test Optuna's core functionality.

Description of the changes

Remove python 3.6 from python-version in .github/workflows/tests-integration.yml and .github/workflows/tests-mpi.yml and run branches depending on python version.

@nzw0301 nzw0301 added the CI Continuous integration. label Sep 10, 2022
@nzw0301
Copy link
Copy Markdown
Member Author

nzw0301 commented Sep 10, 2022

Can we remove python_version>'3.6' in setup.py's integration part? This is because we don't need python 3.6 for integration tests anymore by this PR.

@contramundum53 contramundum53 self-assigned this Sep 12, 2022
@nzw0301
Copy link
Copy Markdown
Member Author

nzw0301 commented Sep 12, 2022

I suppose Branch protection rules waits for tests-integration (3.6), which is removed by this PR.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Sep 19, 2022
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 added this to the v3.1.0 milestone Sep 20, 2022
@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Sep 20, 2022
@toshihikoyanase toshihikoyanase self-assigned this Sep 26, 2022
Copy link
Copy Markdown
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll make tests-integration (3.6) optional to merge this PR tomorrow.

@contramundum53 contramundum53 merged commit 5230030 into optuna:master Sep 27, 2022
@nzw0301 nzw0301 deleted the drop-python3.6-from-integration-ci branch September 27, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants