Add deprecation notes for OptimizleyConfigV2#360
Merged
The-inside-man merged 3 commits intomasterfrom Sep 16, 2021
Merged
Conversation
jaeopt
approved these changes
Sep 16, 2021
Contributor
jaeopt
left a comment
There was a problem hiding this comment.
Can you change the PR note. OptimizelyConfig experiments_map is not deprecated while that for OptimizelyFeature is. It's still valid for legacy projects. Other than that, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizelyFeature experiments_map is deprecated, users shall use experiment_rules and delivery_rules.
Test plan
Issues