Fix Impression Events - Variation lookup by id and Experiment id#350
Merged
The-inside-man merged 2 commits intomasterfrom Jul 15, 2021
Merged
Fix Impression Events - Variation lookup by id and Experiment id#350The-inside-man merged 2 commits intomasterfrom
The-inside-man merged 2 commits intomasterfrom
Conversation
…r impression events.
msohailhussain
approved these changes
Jul 15, 2021
Contributor
msohailhussain
left a comment
There was a problem hiding this comment.
lgtm once license header is updated.
The-inside-man
added a commit
that referenced
this pull request
Jul 15, 2021
* Fix in user_event_factory to use experiment_id to lookup variation for impression events. * Update License Header to 2021.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues