fix: change datafile accessor feature to return a string representation of datafile#283
Conversation
optimizely/project_config.py
Outdated
|
|
||
| config = json.loads(datafile) | ||
| self._datafile = datafile | ||
| self._datafile = str(datafile) |
There was a problem hiding this comment.
You will have to specify encoding here if I understand correctly. It should be utf-8.
Python 2 by default does ascii and Python 3 does utf-8.
aliabbasrizvi
left a comment
There was a problem hiding this comment.
Small change needed.
optimizely/project_config.py
Outdated
|
|
||
| config = json.loads(datafile) | ||
| self._datafile = datafile | ||
| self._datafile = str(datafile) |
There was a problem hiding this comment.
This is per @mjc1283 's request. That's fine w me if we want to return a string. though SOhail prefers JSON, but Peter found a way to still return string and then convert it back to JSON in the FSC.
mjc1283
left a comment
There was a problem hiding this comment.
LGTM. Please wait for Ali's approval before merging.
…e array of the datafile
495f8da to
6357c04
Compare
aliabbasrizvi
left a comment
There was a problem hiding this comment.
This should be good now, but we should only merge when we have run against compatibility suite tests.
|
Reran FSC tests with datafile accessor flag and passed. Merging. |
Summary
stringtype instead of previousbytestypeTest Plan
Note
fullstack_prod_suitebecause thebytesdatafile was not iterable, so I changed it to return astring