updated code and made state as pass and throw suggestion instead of error for missing spec in CR.#6245
Merged
laxmikantbpandhare merged 5 commits intoJan 11, 2023
Conversation
d6cf360 to
e401e4d
Compare
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
everettraven
approved these changes
Jan 11, 2023
everettraven
left a comment
Contributor
There was a problem hiding this comment.
A teeny non-blocking nit. Other than that looks good to me!
/lgtm
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
|
New changes are detected. LGTM label has been removed. |
Member
|
/cherry-pick v1.25.x |
|
@rashmigottipati: new pull request created: #6259 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rashmigottipati
pushed a commit
to rashmigottipati/operator-sdk
that referenced
this pull request
Jan 26, 2023
…rror for missing spec in CR. (operator-framework#6245) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
rashmigottipati
pushed a commit
to rashmigottipati/operator-sdk
that referenced
this pull request
Jan 26, 2023
…rror for missing spec in CR. (operator-framework#6245) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati
added a commit
that referenced
this pull request
Jan 26, 2023
…rror for missing spec in CR. (#6245) (#6266) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com> Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will fix - #5313
Description of the change:
Removed error and throw suggestion when there is no spec in the CR
Motivation for the change:
In many valid cases, there will not be specs available in the CR
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs