Skip to content

(bugfix): bump operator-framework/api dependency version#6227

Merged
everettraven merged 1 commit into
operator-framework:masterfrom
everettraven:bugfix/bump-of-api
Dec 22, 2022
Merged

(bugfix): bump operator-framework/api dependency version#6227
everettraven merged 1 commit into
operator-framework:masterfrom
everettraven:bugfix/bump-of-api

Conversation

@everettraven

Copy link
Copy Markdown
Contributor

Description of the change:

Motivation for the change:

  • Fixes a bug in the k8s 1.25 validation logic when running operator-sdk bundle validate ... that was caused by the validation logic not checking both the group and the resource when validating permissions in the CSV. This bug would cause a warning to be issued to all resources with the same name regardless of what group they are in.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci openshift-ci Bot requested review from fabianvf and jmrodri December 22, 2022 15:25
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy December 22, 2022 15:25 — with GitHub Actions Inactive
@oceanc80

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2022
@everettraven everettraven merged commit ad9447b into operator-framework:master Dec 22, 2022
@everettraven

Copy link
Copy Markdown
Contributor Author

/cherry-pick v1.26.x

@openshift-cherrypick-robot

Copy link
Copy Markdown

@everettraven: new pull request created: #6231

Details

In response to this:

/cherry-pick v1.26.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rashmigottipati

Copy link
Copy Markdown
Member

/cherry-pick v1.25.x

@openshift-cherrypick-robot

Copy link
Copy Markdown

@rashmigottipati: new pull request created: #6260

Details

In response to this:

/cherry-pick v1.25.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rashmigottipati pushed a commit to rashmigottipati/operator-sdk that referenced this pull request Jan 25, 2023
…amework#6227)

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati added a commit that referenced this pull request Jan 25, 2023
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Co-authored-by: Bryce Palmer <bpalmer@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants