fix run bundle(-upgrade) to no longer stall#6040
Merged
everettraven merged 3 commits intoSep 26, 2022
Merged
Conversation
Contributor
Author
|
/cc @jmrodri |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
82064de to
06dde43
Compare
Contributor
Author
|
sanity check seems to be failing due to a change in the |
dacamposol
pushed a commit
to dacamposol/operator-sdk
that referenced
this pull request
Oct 6, 2022
* fix run bundle(-upgrade) to no longer stall Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add changelog Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add err check and log warning for linter Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
operator-sdk run bundle(-upgrade)process to no longer stall due a file lock clash. Instead, we now create a temporary registry directory based on the image references being used in thefbcutil.RenderRefs()functionMotivation for the change:
operator-sdk run bundle(-upgrade)subcommands stall #6039Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs