Skip to content

Bug 2037208: handle arm64#5480

Merged
jmrodri merged 1 commit into
operator-framework:masterfrom
jmrodri:bug2037208
Aug 24, 2022
Merged

Bug 2037208: handle arm64#5480
jmrodri merged 1 commit into
operator-framework:masterfrom
jmrodri:bug2037208

Conversation

@jmrodri

@jmrodri jmrodri commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
  • update Makefiles
  • regenerate samples using the new update

Signed-off-by: jesus m. rodriguez jesusr@redhat.com

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@jmrodri

jmrodri commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

/hold

needs changelog

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
@jmrodri

jmrodri commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
ryantking
ryantking reviewed Jan 7, 2022
View reviewed changes

@ryantking ryantking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with darwin's default sed, which is different from GNU's.

asmacdo
asmacdo approved these changes Jan 7, 2022
View reviewed changes

@asmacdo asmacdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@jmrodri

jmrodri commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

/hold
there is one scenario that I think is broken. Will verify and remove hold.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2022
@jmrodri

jmrodri commented Feb 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

The scenario is that we try to download opm and there was no arm64 opm until release 1.20.

@joelanford

joelanford commented Mar 3, 2022

Copy link
Copy Markdown
Member

/approve

@openshift-bot

openshift-bot commented Jun 1, 2022

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2022
@openshift-bot

openshift-bot commented Jul 1, 2022

Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 1, 2022
@openshift-bot

openshift-bot commented Jul 31, 2022

Copy link
Copy Markdown

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Jul 31, 2022
@openshift-ci

openshift-ci Bot commented Jul 31, 2022

Copy link
Copy Markdown

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri

jmrodri commented Aug 1, 2022

Copy link
Copy Markdown
Member Author

I will retest this PR and reopen.

@jmrodri jmrodri reopened this Aug 1, 2022
@jmrodri
Bug 2037208: handle arm64
f180a59 
* update Makefiles
* regenerate samples using the new update
* add changelog describing the change

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-ci

openshift-ci Bot commented Aug 24, 2022

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@jmrodri

jmrodri commented Aug 24, 2022

Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@jmrodri jmrodri merged commit 7ff9007 into operator-framework:master Aug 24, 2022
dacamposol pushed a commit to dacamposol/operator-sdk that referenced this pull request Oct 6, 2022
@jmrodri @dacamposol
Bug 2037208: handle arm64 (operator-framework#5480)
2603465 
* update Makefiles
* regenerate samples using the new update
* add changelog describing the change

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>

Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@marc-obrien marc-obrien Awaiting requested review from marc-obrien

2 more reviewers

@ryantking ryantking ryantking left review comments

@asmacdo asmacdo asmacdo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asmacdo asmacdo

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmrodri @joelanford @openshift-bot @asmacdo @ryantking