✨ adds some extra text context to sql statement errors#953
Merged
openshift-merge-robot merged 1 commit intoMay 24, 2022
Merged
✨ adds some extra text context to sql statement errors#953openshift-merge-robot merged 1 commit into
openshift-merge-robot merged 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 52.42% 52.35% -0.07%
==========================================
Files 103 103
Lines 9228 9238 +10
==========================================
- Hits 4838 4837 -1
- Misses 3468 3479 +11
Partials 922 922
Continue to review full report at Codecov.
|
grokspawn
reviewed
May 17, 2022
grokspawn
reviewed
May 17, 2022
grokspawn
reviewed
May 17, 2022
grokspawn
requested changes
May 18, 2022
Contributor
|
/lgtm |
grokspawn
approved these changes
May 18, 2022
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
dinhxuanvu
reviewed
May 24, 2022
dinhxuanvu
left a comment
Member
There was a problem hiding this comment.
Looking good. Just one question.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, camilamacedo86, dinhxuanvu, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Tested locally
Closes #952 because, via OPM, we can only provide extra info to clarify the scenario/why the error occurs.