Skip to content

OPRUN-4642: Update to golang-1.26.3#2001

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:masterfrom
tmshort:update-golang-1.26
Jun 5, 2026
Merged

OPRUN-4642: Update to golang-1.26.3#2001
openshift-merge-bot[bot] merged 1 commit into
operator-framework:masterfrom
tmshort:update-golang-1.26

Conversation

@tmshort

@tmshort tmshort commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copilot AI review requested due to automatic review settings June 4, 2026 18:24
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 4, 2026

Copy link
Copy Markdown

@tmshort: This pull request references OPRUN-4642 which is a valid jira issue.

Details

In response to this:

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from grokspawn and pedjak June 4, 2026 18:24
Copilot AI reviewed Jun 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@tmshort tmshort added the go-verdiff-override Override go-verdiff test. label Jun 4, 2026
@tmshort
Update to golang-1.26.3
8ff53ed 
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort force-pushed the update-golang-1.26 branch from ff7fda5 to 8ff53ed Compare June 4, 2026 18:36
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.75%. Comparing base (2e03f89) to head (8ff53ed).

Files with missing lines Patch % Lines
alpha/declcfg/declcfg_to_model.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2001   +/-   ##
=======================================
  Coverage   58.75%   58.75%           
=======================================
  Files         141      141           
  Lines       13426    13426           
=======================================
  Hits         7889     7889           
  Misses       4325     4325           
  Partials     1212     1212

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot stopped reviewing on behalf of tmshort due to an error June 4, 2026 19:23
Copilot had to stop work due to a timeout.
fgiudici
fgiudici reviewed Jun 5, 2026
View reviewed changes

@fgiudici fgiudici left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread alpha/declcfg/declcfg_to_model.go
for j, entry := range deprecation.Entries {
if entry.Reference.Schema == "" {
return nil, fmt.Errorf("schema must be set for deprecation entry [%v] for package %q", deprecation.Package, j)
return nil, fmt.Errorf("schema must be set for deprecation entry [%d] for package %q", j, deprecation.Package)

@fgiudici fgiudici Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@perdasilva

perdasilva commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@perdasilva

perdasilva commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

/override codecov/patch

@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@perdasilva: Overrode contexts on behalf of perdasilva: codecov/patch

Details

In response to this:

/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9c948cd into operator-framework:master Jun 5, 2026
13 of 14 checks passed
@tmshort tmshort deleted the update-golang-1.26 branch June 5, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgiudici fgiudici fgiudici left review comments

Copilot code review Copilot Copilot left review comments

@grokspawn grokspawn Awaiting requested review from grokspawn

@pedjak pedjak Awaiting requested review from pedjak

Assignees

@fgiudici fgiudici

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. go-verdiff-override Override go-verdiff test. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmshort @openshift-ci-robot @perdasilva @fgiudici