Skip to content

Bump k8s libraries to v0.30.0#1297

Merged
openshift-merge-bot[bot] merged 3 commits into
operator-framework:masterfrom
Neo2308:feature/master/bump-k8s-0.30.0
May 15, 2024
Merged

Bump k8s libraries to v0.30.0#1297
openshift-merge-bot[bot] merged 3 commits into
operator-framework:masterfrom
Neo2308:feature/master/bump-k8s-0.30.0

Conversation

@Neo2308

@Neo2308 Neo2308 commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of the change:

  • Bump k8s libraries to v0.30.0
  • Bump controller-runtime to v0.18.2

Motivation for the change:
Relates to: operator-framework/operator-sdk#6730

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2024
@openshift-ci

openshift-ci Bot commented May 3, 2024

Copy link
Copy Markdown
Contributor

Hi @Neo2308. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from anik120 and benluddy May 3, 2024 08:51
@Neo2308 Neo2308 mentioned this pull request May 3, 2024
Closed
12 tasks
@codecov

codecov Bot commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.06%. Comparing base (5b5181b) to head (867afc8).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   50.05%   50.06%           
=======================================
  Files         135      135           
  Lines       12995    12995           
=======================================
+ Hits         6505     6506    +1     
+ Misses       5406     5405    -1     
  Partials     1084     1084

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva mentioned this pull request May 3, 2024
Closed
@perdasilva

perdasilva commented May 3, 2024

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2024
perdasilva
perdasilva reviewed May 3, 2024
View reviewed changes
Comment thread go.mod Outdated
@perdasilva

perdasilva commented May 14, 2024

Copy link
Copy Markdown
Contributor

@Neo2308 could you please bump controller-runtime to v0.18.2 so we can close #1305

everettraven
everettraven reviewed May 14, 2024
View reviewed changes
Comment thread go.mod Outdated
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
Neo2308 added 3 commits May 15, 2024 10:04
@Neo2308
Update k8s dependencies to v0.30.0
f4a9912 
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@Neo2308
Use operator-framework/api@v0.24.0
d02fe62 
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@Neo2308
Updated controller-runtime@v0.18.2
867afc8 
Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
@Neo2308 Neo2308 force-pushed the feature/master/bump-k8s-0.30.0 branch from 0751542 to 867afc8 Compare May 15, 2024 04:35
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@Neo2308

Neo2308 commented May 15, 2024

Copy link
Copy Markdown
Contributor Author

@perdasilva / @everettraven can you review this PR now?

@perdasilva

perdasilva commented May 15, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@perdasilva

perdasilva commented May 15, 2024

Copy link
Copy Markdown
Contributor

@grokspawn can we merge this one? Should be ok, right?

@perdasilva perdasilva mentioned this pull request May 15, 2024
Closed
everettraven
everettraven approved these changes May 15, 2024
View reviewed changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented May 15, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, Neo2308

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 7de2fc5 into operator-framework:master May 15, 2024
@github-actions github-actions Bot mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilva perdasilva perdasilva left review comments

@everettraven everettraven everettraven approved these changes

@grokspawn grokspawn grokspawn approved these changes

@anik120 anik120 Awaiting requested review from anik120

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@perdasilva perdasilva

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Neo2308 @perdasilva @everettraven @grokspawn @openshift-merge-robot