Skip to content

OCPBUGS-52340: Ensure that PSA label use k8s version supported on the project#592

Closed
camilamacedo86 wants to merge 1 commit into
operator-framework:masterfrom
camilamacedo86:fix-psa-label
Closed

OCPBUGS-52340: Ensure that PSA label use k8s version supported on the project#592
camilamacedo86 wants to merge 1 commit into
operator-framework:masterfrom
camilamacedo86:fix-psa-label

Conversation

@camilamacedo86

@camilamacedo86 camilamacedo86 commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

Description of the change:
In this commit, a new Makefile target update-k8s-values was created to automatically update the
pod-security.kubernetes.io/*-version values (enforceVersion, auditVersion, warnVersion)
in the Helm chart's values.yaml file.

These values now align with the Kubernetes API version defined in go.mod, instead of using latest. This ensures better compatibility and avoids issues with unsupported versions in Kubernetes PSA.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-42526, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

I will need to create an OCPBUG for each version :-(
I also pushed the check: openshift/release#62239
But we can only merge that after cherry-picking it up to the OCP release 4.16.

@tmshort

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-42526: (fix): Ensure that PSA label use k8s version supported on the project (fix): Ensure that PSA label use k8s version supported on the project (OCPBUGS-42526) Feb 28, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 28, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Description of the change:
In this commit, a new Makefile target update-k8s-values was created to automatically update the
pod-security.kubernetes.io/*-version values (enforceVersion, auditVersion, warnVersion)
in the Helm chart's values.yaml file.

These values now align with the Kubernetes API version defined in go.mod, instead of using latest. This ensures better compatibility and avoids issues with unsupported versions in Kubernetes PSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 28, 2025
@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-operator

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

2 similar comments
@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test okd-scos-e2e-aws-ovn

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

3 similar comments
@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

The error faced has no relation with the change :-(

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@jianzhangbjz

Copy link
Copy Markdown
Contributor

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-42526
/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Mar 4, 2025
@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

1 similar comment
@camilamacedo86

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console-olm

@camilamacedo86 camilamacedo86 changed the title (fix): Ensure that PSA label use k8s version supported on the project (OCPBUGS-42526) OCPBUGS-52340: Ensure that PSA label use k8s version supported on the project Mar 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 5, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52340, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description of the change:
In this commit, a new Makefile target update-k8s-values was created to automatically update the
pod-security.kubernetes.io/*-version values (enforceVersion, auditVersion, warnVersion)
in the Helm chart's values.yaml file.

These values now align with the Kubernetes API version defined in go.mod, instead of using latest. This ensures better compatibility and avoids issues with unsupported versions in Kubernetes PSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 5, 2025
@openshift-ci

openshift-ci Bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console-olm 28c530f link true /test e2e-gcp-console-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianzhangbjz

Copy link
Copy Markdown
Contributor

Based on https://redhat-internal.slack.com/archives/C06KP34REFJ/p1741224828143489?thread_ts=1739880491.760029&cid=C06KP34REFJ, we should use the latest instead of the pinned version.

@jianzhangbjz

jianzhangbjz commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
@jianzhangbjz

Copy link
Copy Markdown
Contributor

/remove-label qe-approved

@openshift-ci openshift-ci Bot removed the qe-approved Signifies that QE has signed off on this PR label Mar 6, 2025
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52340, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

Description of the change:
In this commit, a new Makefile target update-k8s-values was created to automatically update the
pod-security.kubernetes.io/*-version values (enforceVersion, auditVersion, warnVersion)
in the Helm chart's values.yaml file.

These values now align with the Kubernetes API version defined in go.mod, instead of using latest. This ensures better compatibility and avoids issues with unsupported versions in Kubernetes PSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86

Copy link
Copy Markdown
Contributor Author

Closing since QE would like to set latest instead

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@camilamacedo86: This pull request references Jira Issue OCPBUGS-52340. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Description of the change:
In this commit, a new Makefile target update-k8s-values was created to automatically update the
pod-security.kubernetes.io/*-version values (enforceVersion, auditVersion, warnVersion)
in the Helm chart's values.yaml file.

These values now align with the Kubernetes API version defined in go.mod, instead of using latest. This ensures better compatibility and avoids issues with unsupported versions in Kubernetes PSA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz

Copy link
Copy Markdown
Contributor

This PR was replaced by #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants