Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

🌱 bump ginkgo to 2.21.0#456

Merged
grokspawn merged 1 commit into
operator-framework:mainfrom
grokspawn:dependabot-bingo-group
Nov 15, 2024
Merged

🌱 bump ginkgo to 2.21.0#456
grokspawn merged 1 commit into
operator-framework:mainfrom
grokspawn:dependabot-bingo-group

Conversation

@grokspawn

@grokspawn grokspawn commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

This bumps ginkgo to 2.21.0 since dependabot does not bump go.mod and .bingo/* dependencies in the same PR.

@grokspawn grokspawn requested a review from a team as a code owner November 12, 2024 20:28
@codecov

codecov Bot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (f279c4c) to head (9d9c45c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn force-pushed the dependabot-bingo-group branch from 4055a72 to bf1a06a Compare November 12, 2024 20:40
@grokspawn grokspawn changed the title 🌱 bump ginkgo to 2.21.0 and set up a dependabot group to try to group go.mod and bingo dependency bumps 🌱 bump ginkgo to 2.21.0 Nov 12, 2024
@grokspawn grokspawn force-pushed the dependabot-bingo-group branch 2 times, most recently from 9211d63 to fb7c4e7 Compare November 12, 2024 22:33

@camilamacedo86 camilamacedo86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bump.
I assume that it has been used on the tests and the ci is passing

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@camilamacedo86

Copy link
Copy Markdown
Contributor

/lgtm cancel
/approve cancel

@grokspawn

It seems that we have an issue to build it

Run hack/scripts/check-go-version.sh "4d6327f8d20e6a22c310b8ccae69e2eec63bd0a7"
Found golang version: 1.22.5
./.bingo/go.mod: Skipping, no version found
./.bingo/ginkgo.mod: 1.22.0: Updated golang version from 1.22
Error: Process completed with exit code 1.

See the CI: https://github.com/operator-framework/catalogd/actions/runs/11806891013/job/32892465153?pr=456

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@camilamacedo86

Copy link
Copy Markdown
Contributor

/approve cancel

@grokspawn

Copy link
Copy Markdown
Contributor Author

/lgtm cancel /approve cancel

@grokspawn

It seems that we have an issue to build it

Run hack/scripts/check-go-version.sh "4d6327f8d20e6a22c310b8ccae69e2eec63bd0a7"
Found golang version: 1.22.5
./.bingo/go.mod: Skipping, no version found
./.bingo/ginkgo.mod: 1.22.0: Updated golang version from 1.22
Error: Process completed with exit code 1.

See the CI: https://github.com/operator-framework/catalogd/actions/runs/11806891013/job/32892465153?pr=456

This is not required CI, and it looks like the script isn't happy about how bingo represented the go version with the third octet (1.22.0) whereas that is correct.
But there's no actual error here.

@grokspawn grokspawn force-pushed the dependabot-bingo-group branch from fb7c4e7 to 6c102ad Compare November 15, 2024 14:07
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the dependabot-bingo-group branch from 6c102ad to 9d9c45c Compare November 15, 2024 15:44
@grokspawn

Copy link
Copy Markdown
Contributor Author

go-verdiff fixed by #458

@grokspawn grokspawn added this pull request to the merge queue Nov 15, 2024
Merged via the queue into operator-framework:main with commit ca44dd9 Nov 15, 2024
@grokspawn grokspawn deleted the dependabot-bingo-group branch November 15, 2024 16:04
camilamacedo86 pushed a commit to camilamacedo86/catalogd that referenced this pull request Nov 18, 2024
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants