This repository was archived by the owner on Mar 3, 2025. It is now read-only.
✨ adding additional waits to prevent e2e cert-manager failures#441
Merged
Conversation
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 37.83% 37.83%
=======================================
Files 15 15
Lines 1208 1208
=======================================
Hits 457 457
Misses 701 701
Partials 50 50 ☔ View full report in Codecov by Sentry. |
tmshort
reviewed
Oct 21, 2024
| kubectl_wait "cert-manager" "deployment/cert-manager" "60s" | ||
| kubectl wait mutatingwebhookconfigurations/cert-manager-webhook --for=jsonpath='{.webhooks[0].clientConfig.caBundle}' --timeout=60s | ||
| kubectl wait validatingwebhookconfigurations/cert-manager-webhook --for=jsonpath='{.webhooks[0].clientConfig.caBundle}' --timeout=60s | ||
| kubectl apply -f "${catalogd_manifest}" |
Contributor
There was a problem hiding this comment.
Nit, loss of a blank line here...
tmshort
approved these changes
Oct 21, 2024
Contributor
Author
|
upgrade-e2e script cannot pass until #440 merges. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've encountered cert-manager failures in e2e, installing from release, and running the demo updates. This introduces some additional waits on cert-manager resources to attempt to reduce these.