This repository was archived by the owner on Mar 3, 2025. It is now read-only.
✨ Adding Availability enum to catalog spec#421
Merged
joelanford merged 3 commits intoOct 17, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 37.31% 38.36% +1.05%
==========================================
Files 15 15
Lines 922 941 +19
==========================================
+ Hits 344 361 +17
- Misses 529 530 +1
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. |
401f2d0 to
9b9a7af
Compare
joelanford
reviewed
Oct 3, 2024
everettraven
reviewed
Oct 3, 2024
bentito
reviewed
Oct 3, 2024
8326637 to
650c934
Compare
joelanford
reviewed
Oct 14, 2024
joelanford
reviewed
Oct 14, 2024
b5245a5 to
5cbabe2
Compare
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
5cbabe2 to
eba52e7
Compare
Member
|
Looking pretty good. Can you also add some tests? I'm thinking primarily focused on unit tests, but also an e2e that sets up a catalog as "Enabled", then disables it, and checks that:
|
joelanford
reviewed
Oct 15, 2024
a72fc12 to
6cd0ea3
Compare
joelanford
reviewed
Oct 16, 2024
4 tasks
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
6cd0ea3 to
70a5536
Compare
Member
|
Implementation looks good to me! Are you planning to add tests to this PR? |
Member
Author
yeah, working on that. Will remove the WIP attached to the PR once that is done. |
34af72b to
b6c304c
Compare
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
b6c304c to
a3281bf
Compare
joelanford
approved these changes
Oct 17, 2024
LalatenduMohanty
added a commit
to LalatenduMohanty/catalogd
that referenced
this pull request
Oct 25, 2024
This is a follow-up from the previous PR operator-framework#421 i.e. commit d320249 Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.