Skip to content

Update modules to support k8s v0.29.2#313

Closed
OchiengEd wants to merge 4 commits into
operator-framework:masterfrom
OchiengEd:add_k8s_v0.29.2
Closed

Update modules to support k8s v0.29.2#313
OchiengEd wants to merge 4 commits into
operator-framework:masterfrom
OchiengEd:add_k8s_v0.29.2

Conversation

@OchiengEd

@OchiengEd OchiengEd commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

Add support for kubernetes v0.29.2 in the Operator Framework/api project dependencies.

@openshift-ci openshift-ci Bot requested review from dinhxuanvu and jmrodri February 20, 2024 14:12
@openshift-ci

openshift-ci Bot commented Feb 20, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: OchiengEd
Once this PR has been reviewed and has the lgtm label, please assign jmrodri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (4454fc8) to head (43d2876).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files          42       42           
  Lines        4011     4011           
=======================================
  Hits         1703     1703           
  Misses       2156     2156           
  Partials      152      152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OchiengEd OchiengEd closed this Feb 20, 2024
@OchiengEd OchiengEd reopened this Feb 20, 2024
@Neo2308 Neo2308 mentioned this pull request Feb 21, 2024
Closed
13 tasks
@Neo2308

Neo2308 commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

@OchiengEd it seems there changes may be required in a couple of more files, could you refer to a similar PR from before: https://github.com/operator-framework/api/pull/292/files#diff-75ef0ffb5d877865f116117605304acde0046b6fd17cd1014376d020d39c4a17

Neo2308
Neo2308 reviewed Feb 22, 2024
View reviewed changes
Comment thread go.mod Outdated
@OchiengEd OchiengEd marked this pull request as draft March 1, 2024 16:24
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@Neo2308 Neo2308 mentioned this pull request Mar 6, 2024
Merged
@OchiengEd OchiengEd closed this Mar 6, 2024
@OchiengEd OchiengEd reopened this Mar 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2024
OchiengEd and others added 4 commits March 18, 2024 14:49
@OchiengEd
Update modules to support k8s v0.29.2
c3db53c 
Add support for kubernetes v0.29.2 in the Operator Framework api project
dependencies.

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@OchiengEd
Bump versions of controller-runtime among other modules
41ed530 
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@Neo2308 @OchiengEd
Update controller tools and regen files
591f5d6 
Updated controller tools to v0.14.0.
Refreshed auto-generated files.
@OchiengEd
Recreate auto-generated code through make targets
43d2876 
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@OchiengEd OchiengEd closed this Mar 18, 2024
@OchiengEd OchiengEd deleted the add_k8s_v0.29.2 branch March 18, 2024 20:21
@Neo2308 Neo2308 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@jmrodri jmrodri Awaiting requested review from jmrodri

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@Neo2308 Neo2308 Neo2308 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OchiengEd @Neo2308 @openshift-merge-robot