[bot] Code cleanup#2421
Merged
Merged
Conversation
Copilot AI
added a commit
that referenced
this pull request
Feb 20, 2026
… built The database migration tests have been failing since Feb 16th because commit 1328399 moved the `qa` module in `clients/java/pom.xml` into a `distro` profile without adding `activeByDefault=true`. Root cause: - `clients/java/pom.xml`'s `distro` profile lacked `activeByDefault=true`, so the `qa` module (providing `engine-variable-test`) was never included in the build reactor. - `clients/java/client/pom.xml`'s `distro` profile HAS `activeByDefault=true`, so it always declared a dependency on `engine-variable-test`, causing a dependency resolution error. Fix: - Added `activeByDefault=true` to the `distro` profile in `clients/java/pom.xml` so `qa` is included in normal and migration test builds. - Added `maven.deploy.skip=true` to `clients/java/qa/pom.xml` to prevent QA artifacts from being deployed to Maven Central (preserving the original intent of excluding QA from snapshot deployments). The snapshot deployment workflow already uses `-Psonatype-oss-snapshot,-distro` which explicitly deactivates `distro`, so QA modules remain excluded from snapshot deployments. Fixes #2421 Co-authored-by: kthoms <265597+kthoms@users.noreply.github.com>
kthoms
added a commit
that referenced
this pull request
Feb 23, 2026
… built The database migration tests have been failing since Feb 16th because commit 1328399 moved the `qa` module in `clients/java/pom.xml` into a `distro` profile without adding `activeByDefault=true`. Root cause: - `clients/java/pom.xml`'s `distro` profile lacked `activeByDefault=true`, so the `qa` module (providing `engine-variable-test`) was never included in the build reactor. - `clients/java/client/pom.xml`'s `distro` profile HAS `activeByDefault=true`, so it always declared a dependency on `engine-variable-test`, causing a dependency resolution error. Fix: - Added `activeByDefault=true` to the `distro` profile in `clients/java/pom.xml` so `qa` is included in normal and migration test builds. - Added `maven.deploy.skip=true` to `clients/java/qa/pom.xml` to prevent QA artifacts from being deployed to Maven Central (preserving the original intent of excluding QA from snapshot deployments). The snapshot deployment workflow already uses `-Psonatype-oss-snapshot,-distro` which explicitly deactivates `distro`, so QA modules remain excluded from snapshot deployments. Fixes #2421 Co-authored-by: kthoms <265597+kthoms@users.noreply.github.com>
kthoms
added a commit
that referenced
this pull request
Feb 23, 2026
…t failures (#2430) The database migration tests have been failing since Feb 16th because commit 1328399 moved the `qa` module in `clients/java/pom.xml` into a `distro` profile without adding `activeByDefault=true`. Root cause: - `clients/java/pom.xml`'s `distro` profile lacked `activeByDefault=true`, so the `qa` module (providing `engine-variable-test`) was never included in the build reactor. - `clients/java/client/pom.xml`'s `distro` profile HAS `activeByDefault=true`, so it always declared a dependency on `engine-variable-test`, causing a dependency resolution error. Fix: - Added `activeByDefault=true` to the `distro` profile in `clients/java/pom.xml` so `qa` is included in normal and migration test builds. - Added `maven.deploy.skip=true` to `clients/java/qa/pom.xml` to prevent QA artifacts from being deployed to Maven Central (preserving the original intent of excluding QA from snapshot deployments). The snapshot deployment workflow already uses `-Psonatype-oss-snapshot,-distro` which explicitly deactivates `distro`, so QA modules remain excluded from snapshot deployments. Fixes #2421 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kthoms <265597+kthoms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Cleanup
This PR cleans up the code using OpenRewrite recipes configured in
rewrite.yml.