fix(ci): Restore qa module build in clients/java to fix migration test failures#2430
Merged
Conversation
… built The database migration tests have been failing since Feb 16th because commit 1328399 moved the `qa` module in `clients/java/pom.xml` into a `distro` profile without adding `activeByDefault=true`. Root cause: - `clients/java/pom.xml`'s `distro` profile lacked `activeByDefault=true`, so the `qa` module (providing `engine-variable-test`) was never included in the build reactor. - `clients/java/client/pom.xml`'s `distro` profile HAS `activeByDefault=true`, so it always declared a dependency on `engine-variable-test`, causing a dependency resolution error. Fix: - Added `activeByDefault=true` to the `distro` profile in `clients/java/pom.xml` so `qa` is included in normal and migration test builds. - Added `maven.deploy.skip=true` to `clients/java/qa/pom.xml` to prevent QA artifacts from being deployed to Maven Central (preserving the original intent of excluding QA from snapshot deployments). The snapshot deployment workflow already uses `-Psonatype-oss-snapshot,-distro` which explicitly deactivates `distro`, so QA modules remain excluded from snapshot deployments. Fixes #2421 Co-authored-by: kthoms <265597+kthoms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken database migration tests
fix(ci): Restore qa module build in clients/java to fix migration test failures
Feb 20, 2026
kthoms
approved these changes
Feb 22, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the clients/java/qa module to the default Maven reactor build so that migration/database upgrade tests can resolve engine-variable-test from the local reactor again, while still preventing QA artifacts from being deployed.
Changes:
- Activate the
clients/javadistroprofile by default so theqamodule is built in standard builds. - Set
maven.deploy.skip=trueforclients/java/qato avoid publishing QA artifacts duringmvn deploy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
clients/java/pom.xml |
Activates the distro profile by default to include the qa module in normal reactor builds. |
clients/java/qa/pom.xml |
Skips deployment of QA artifacts to preserve the intent of excluding them from snapshot/publication workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
1328399049movedclients/java/qainto adistroprofile to exclude it from snapshot deployments, but omittedactiveByDefault=true. This caused a mismatch:clients/java/client'sdistroprofile (which hasactiveByDefault=true) always declares a dependency onengine-variable-test, but the module providing it was never included in the reactor.Changes
clients/java/pom.xml: AddactiveByDefault=trueto thedistroprofile so theqamodule is included in all standard builds (including migration tests running with-PskipFrontendBuild).clients/java/qa/pom.xml: Addmaven.deploy.skip=trueto prevent QA artifacts from being published to Maven Central — preserving the original intent of the Feb 15 refactor.The snapshot deployment job already passes
-Psonatype-oss-snapshot,-distro, which explicitly deactivatesdistro(overridingactiveByDefault), so QA artifacts remain excluded from deployments.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repository.jboss.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/operaton/operaton org.codehaus.plexus.classworlds.launcher.Launcher help:active-profiles -pl clients/java -PskipFrontendBuild -q e.previous t/distro/pom.xml /home/REDACTED/.config/composer/vendor/bin/grep(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/operaton/operaton org.codehaus.plexus.classworlds.launcher.Launcher dependency:resolve -pl clients/java/qa/engine-variable-test -PskipFrontendBuild -q e.previous om.xml rgo/bin/grep aton 17/pom.xml ndor/bin/git grep(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/operaton/operaton org.codehaus.plexus.classworlds.launcher.Launcher validate -f clients/java/pom.xml -PskipFrontendBuild -l e.previous odules/webapps/pom.xml grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.