Unify OSS and internal logging libraries.#29477
Merged
copybara-service[bot] merged 1 commit intomainfrom Aug 26, 2025
Merged
Conversation
397ad88 to
5fada6a
Compare
df84bbe to
993b51b
Compare
fa911c6 to
16119a7
Compare
This removes the duplicated implementation of `LOG`, `VLOG` and `CHECK` macros and relies directly on the implementation provided by Abseil. TSL logging is not consistently used in XLA. Sometime the Abseil logging headers are included instead. This is not a problem internally because TSL logging aliases Abseil logging. However in OSS, TSL logging is a custom logging library. Abseil logging doesn't recognise the `TF_CPP_MAX_VLOG_LEVEL` and `TF_CPP_VMODULE` environment variables while OSS TSL logging doesn't recognise the `--vmodule` and `--v` flags. To preserve backward compatibility in OSS, we run static initialisation logic that initialises Abseil logging from the `TF_CPP_MIN_LOG_LEVEL`/`TF_CPP_MAX_VLOG_LEVEL`/`TF_CPP_VMODULE` env variables. PiperOrigin-RevId: 799665233
16119a7 to
07a3afe
Compare
bhavya01
added a commit
to pytorch/xla
that referenced
this pull request
Oct 6, 2025
This PR updates the following pins: - PyTorch: pytorch/pytorch@928ac57 to pytorch/pytorch@21fec65 (v2.9.0-rc5) - OpenXLA: openxla/xla@92f7b59 to openxla/xla@9a9aa0e - `libtpu`: 0.0.21 to 0.0.24 - JAX (and `jaxlib`): 0.7.1 to 0.8.0 **Key Changes:** - `@python` was replaced by `@rules_python` at `BUILD` file (ref: [jax-ml/jax#31709](jax-ml/jax#31709)) - `TF_ATTRIBUTE_NORETURN` was removed in favor of abseil (ref: [openxla/xla#31699](openxla/xla#31699)) - Replaced include of `xla/pjrt/tfrt_cpu_pjrt_client.h` file by `xla/pjrt/cpu/cpu_client.h` in `pjrt_registry.cpp` ([openxla/xla#30936](openxla/xla#30936)) - Moved the old `xla/tsl/platform/default/logging.*` to `torch_xla/csrc/runtime/tsl_platform_logging.*` - They were removed in [openxla/xla#29477](openxla/xla#29477) - Copied them here, temporarily. They should be removed once we update our error throwing macros. - Commented out a few macro definitions, avoiding macro re-definitions **Update (Oct 3):** - Add an OpenXLA patch for fixing `static_assert(false)` for GCC < 13 ([ref](https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=9944ca17c0766623bce260684edc614def7ea761)) - Removed the `flax` pin, since it does not overwrite `jax` anymore - Removed `TPU*` prefix of `jax.experimental.pallas.tpu` components (ref: [jax-ml/jax#29115](jax-ml/jax#29115)) --------- Co-authored-by: Bhavya Bahl <bbahl@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify OSS and internal logging libraries.
This removes the duplicated implementation of
LOG,VLOGandCHECKmacrosand relies directly on the implementation provided by Abseil.
TSL logging is not consistently used in XLA. Sometime the Abseil logging headers are included instead. This is not a problem internally because TSL logging aliases Abseil logging. However in OSS, TSL logging is a custom logging library. Abseil logging doesn't recognise the
TF_CPP_MAX_VLOG_LEVELandTF_CPP_VMODULEenvironment variables while OSS TSL logging doesn't recognise the--vmoduleand--vflags.To preserve backward compatibility in OSS, we run static initialisation logic that initialises Abseil logging from the
TF_CPP_MIN_LOG_LEVEL/TF_CPP_MAX_VLOG_LEVEL/TF_CPP_VMODULEenv variables.