Skip to content

jose: Add Makefile for jose v10#4334

Merged
neheb merged 1 commit intoopenwrt:masterfrom
Tiboris:jose
Apr 3, 2019
Merged

jose: Add Makefile for jose v10#4334
neheb merged 1 commit intoopenwrt:masterfrom
Tiboris:jose

Conversation

@Tiboris
Copy link
Contributor

@Tiboris Tiboris commented May 7, 2017

Signed-off-by: Tibor Dudlák tibor.dudlak@gmail.com

Maintainer: @Tiboris / TBA

Compile tested: (mips, TL-WR842N, 17.01.4, r3560-79f57e422d)

Description:
José is a command line utility for performing various tasks on JSON Object Signing and Encryption (JOSE) objects. José provides a full crypto stack including key generation, signing and encryption.
Project page: https://github.com/latchset/jose

José also depends on jansson >= 2.9

jose also with http-parser

and xinetd is required as dependency for Tang server.
Tang project page: https://github.com/latchset/tang

Thank you.

@Tiboris
Copy link
Contributor Author

Tiboris commented May 7, 2017

José also depends on jansson >= 2.9 (#4289)

I am sorry, but is there way i can define this specific requirement for jansson version>= 2.9 ?
I just found out, that without manually installed package (#4289) opkg downloads and installs version 2.7.

@Tiboris Tiboris force-pushed the jose branch 2 times, most recently from d7c31ab to ba75168 Compare May 7, 2017 15:28
Tiboris added a commit to Tiboris/OpenWrt-SDK-15.05.1-ar71xx that referenced this pull request May 7, 2017
@Tiboris Tiboris force-pushed the jose branch 8 times, most recently from 71d8951 to f7191df Compare May 12, 2017 17:02
@hauke
Copy link
Member

hauke commented Jun 3, 2017

OpenWrt and LEDE do not support two different versions of the same package in the repository. You did it correctly and should add a link to the pull reqeust for the update of jansson into this pull request and make the package just depend on jansson.

@Tiboris
Copy link
Contributor Author

Tiboris commented Jul 17, 2017

@hauke @champtar
Thank you.

@Tiboris Tiboris force-pushed the jose branch 2 times, most recently from 3564e45 to 31ceddb Compare October 30, 2017 15:27
@Tiboris Tiboris force-pushed the jose branch 2 times, most recently from 1c3c15f to d1ab6cb Compare January 6, 2018 15:16
@Tiboris Tiboris changed the title jose: Add Makefile for jose v7 jose: Add Makefile for jose v10 Jan 6, 2018
@Tiboris Tiboris force-pushed the jose branch 4 times, most recently from c1ff3df to 128627b Compare January 11, 2018 09:04
Tiboris added a commit to Tiboris/packages-OpenWrt that referenced this pull request Jan 14, 2018
Tang is lightweight server for binding data to network presence.

Maintainer: @Tiboris

Compile tested: (mips, TL-WR842N, 17.01.4, r3560-79f57e422d)

**Tang requires a few other software libraries:**

1. libhttp-parser:
	- ~openwrt#4334
	- openwrt#5189
		- + upstream patch openwrt#4334
2. xinetd's socket activation

3. jose >= 8:
	- openwrt#4334

**Two new files compared to tang upstream:**
- tangdx : configuration file for xinetd
- tangdw : wrapper for tangd service
	- puts timestamp when service activated, and
	- redirects stderr to log file in /var/log/

**Removed systemd requirement**

Signed-off-by: Tibor Dudlák <tibor.dudlak@gmail.com>
Tiboris added a commit to Tiboris/packages-OpenWrt that referenced this pull request Jan 14, 2018
Tang is lightweight server for binding data to network presence.
---
Tang's source: https://github.com/latchset/tang

Maintainer: @Tiboris

Compile tested: (mips, TL-WR842N, 17.01.4, r3560-79f57e422d)

**Tang requires a few other software libraries:**

1. libhttp-parser:
	- ~openwrt#4334
	- openwrt#5189
		- \+ needs upstream patch openwrt#5446
2. xinetd's socket activation

3. jose >= 8:
	- openwrt#4334

**Two new files compared to tang upstream:**
- tangdx : configuration file for xinetd
- tangdw : wrapper for tangd service
	- puts timestamp when service activated, and
	- redirects stderr to log file in /var/log/

**Removed systemd requirement**

Signed-off-by: Tibor Dudlák <tdudlak@redhat.com>
@Tiboris Tiboris force-pushed the jose branch 3 times, most recently from ba71c70 to 961e610 Compare January 15, 2018 15:00
@Tiboris
Copy link
Contributor Author

Tiboris commented Jan 17, 2018

Do I have to divide this package into two? joselib and josetool?
#4334 (comment)

@champtar
Copy link
Member

@Tiboris OpenWrt is targetting small storage devices, so if josetool is not mandatory, and for exemple tang only require joselib, it make sense to have 2 packages

@Tiboris
Copy link
Contributor Author

Tiboris commented Jan 22, 2018

Hi @champtar,

Thanks for input! I can of course divide it into two packages.
Tang uses jose's tool as dependency to be able to generate keys for advertisement and uses jose's lib as well.

@Tiboris Tiboris force-pushed the jose branch 2 times, most recently from 0821979 to f89bc61 Compare March 7, 2018 18:20
@Tiboris
Copy link
Contributor Author

Tiboris commented Mar 7, 2018

@champtar @hauke Is it allright or should i change something?
Thanks

@Tiboris Tiboris force-pushed the jose branch 2 times, most recently from 5e5d52f to c36d15f Compare July 18, 2018 08:20
@diizzyy
Copy link
Contributor

diizzyy commented Jan 2, 2019

@champtar
Can you do a final review?

@neheb
Copy link
Contributor

neheb commented Mar 29, 2019

@Tiboris can you rebase against current master so that CircleCI is ran?

@Tiboris
Copy link
Contributor Author

Tiboris commented Apr 1, 2019

@neheb Sure, done :)

@neheb
Copy link
Contributor

neheb commented Apr 2, 2019

Just looked at the upstream project. Might be good to backport this: latchset/jose@198f720

Jose is acommand line utility for performing various tasks on JSON
Object Signing and Encryption (JOSE) objects. José provides a full
crypto stack including key generation, signing and encryption.
Added: latchset/jose@198f720

Signed-off-by: Tibor Dudlák <tibor.dudlak@gmail.com>
@Tiboris
Copy link
Contributor Author

Tiboris commented Apr 3, 2019

Nice catch @neheb, thanks for review! Changes pushed.

@Tiboris
Copy link
Contributor Author

Tiboris commented Apr 3, 2019

@neheb Would you mind also looking at #5447 please?

@neheb
Copy link
Contributor

neheb commented Apr 3, 2019

I see no more problems. Merging. I trust you'll take case of this well :).

@neheb neheb merged commit 3ba2e1c into openwrt:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants