Closed
Conversation
Contributor
Author
|
hmmm maybe second and third commit should be merged. thoughts? |
Contributor
Author
|
So it turns out CMake's find_package(Iconv REQUIRED) is completely broken and doesn't work with nls.mk at all. It needs to be overridden. meson's dependency('iconv') works perfectly. I think the best way forward is to remove nls.mk for those packages. |
Contributor
Author
|
Going to mark this as ready. I've fixed most packages currently. Others will be dealt with when libiconv-stub is gone. |
Member
|
If I'm not completely wrong, then this PR makes |
Member
|
@neheb do you want me to run this under the github actions and check if we have additional package not compiled? |
Contributor
Author
|
@Ansuel wouldn’t hurt. |
Contributor
Author
|
@mhei useless how? musl has iconv |
Member
|
@neheb: "useless" is maybe wrong wording, but when looking at the help description of
I mean: previously we removed iconv/gettext functionality mostly completely when this option was not selected, right? The stubs however allowed to compile packages which did not offer selecting iconv/gettext usage during configure/compile time. Now that musl brings "strong for its size, but not comprehensive like glibc’s" iconv support, we don't have such a large impact of this switch anymore as previously. |
Contributor
Author
|
Sure I can update the description. |
Contributor
Author
|
@mhei updated. |
Member
|
Thnx. Just removing the wrong part is ok, but wouldn't it be even better to describe the behavior with musl gettext/iconv implementation? For example:
What do you think? |
gettext (libintl-stub) was removed in commit [1], so the libintl-stub lib and include directories aren't existing anymore. This commit cleans up the INTL flags for the BUILD_NLS=n case. [1] e6f5694 Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net> Reviewed-by: Rosen Penev <rosenp@gmail.com>
This was previously needed for uClibc-ng. Now that it's gone, it can go away in nls.mk too. Signed-off-by: Rosen Penev <rosenp@gmail.com>
No longer used. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
Author
|
I don't like it. OpenWrt also supports glibc, which has builtin iconv as well. |
Member
|
Good point. But if I was an ordinary OpenWrt user, not deeply involved in programming stuff etc., what is the benefit/gain of enabling this option for glibc? Can you describe it? |
No longer relevant. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
Author
|
According to https://lists.gnu.org/archive/html/bug-gnu-libiconv/2010-05/msg00010.html , seems to be a difference in locale dependence. Ordinary OpenWrt users don't use the SDK or build their own packages. Anyway, I made a small change. |
mhei
added a commit
to mhei/packages
that referenced
this pull request
Jul 7, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 9, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 9, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Contributor
Author
|
This is ready for inclusion. ping @Ansuel |
mhei
added a commit
to mhei/packages
that referenced
this pull request
Jul 12, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 14, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 14, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 14, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 14, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Member
|
Merged. Thanks. I'm curious what will show up. I tried running some targets and SDK builds in my cases it all worked fine. |
Contributor
|
This shows up here: |
Member
|
@dhewg true, I think it is also interesting to see what the package builds looks like. so far: a few base packages (strace, binutils, gdb,wolfssl,iproute2,perf,xdp-tools,secilc,qosify,elfutils) show up as well. I've seen those disappear when nls.mk gets updated. hmm, this should have happend, or are the phase2 sticking to a particular sdk? |
Contributor
Author
|
Those should go away when tmp gets wiped. |
Contributor
|
I got those too at first, but it went away from a clean build tree. |
Member
Contributor
Author
|
Not quite. Once that patch is merged, I'll merge neheb/packages@c447510 . edit: actually I wonder if the one on glib2 is even needed... |
mhei
added a commit
to mhei/packages
that referenced
this pull request
Jul 17, 2022
Since the OpenWrt's stub libiconv implementation is now gone, we can build against musl's internal one or the external libiconv implementation. This needs minor adjustements in the makefile to allow PHPs build to choose the right path when cross-compiling. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
neheb
pushed a commit
to neheb/packages
that referenced
this pull request
Jul 18, 2022
Since the OpenWrt's stub libiconv implementation is now gone, and PHP does not build against e.g. musl's internal one, we need to always switch to the external libiconv implementation. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
mhei
added a commit
to openwrt/packages
that referenced
this pull request
Jul 19, 2022
php8: fixup libiconv usage (refs openwrt/openwrt#10024)
SvenRoederer
added a commit
to SvenRoederer/freifunk-berlin-firmware
that referenced
this pull request
Jul 19, 2022
a24a76783 php8: fixup libiconv usage (refs openwrt/openwrt#10024) 45d7e4f6f open-vm-tools: fix compilation without libiconv e702a6605 unbound: update to 1.16.1 59cadc7c6 irqbalance: add meson 61b31a315 Merge pull request #18919 from mhei/php8-full-libiconv
github-actions bot
added a commit
to swirly0p/CTCGFW-packages
that referenced
this pull request
Jul 23, 2022
* 'master' of https://github.com/immortalwrt/packages: ruby: refresh patch ruby: fix build with LibreSSL over v3.5 crelay: update to 0.14.1 docker-compose: Update to version 2.7.0 dawn: update to 2022-07-21 usteer: update to latest HEAD mutt: add PKG_CONFIG_DEPENDS opusfile: add autoreconf geth: update to 1.10.20 libulfius: update to 2.7.10 glib2: disable fortify source wifidog: fix compilation with more recent wolfssl curl: fix compilation with wolfSSL irqbalance: add meson django: bump to version 4.0.6 php8: fixup libiconv usage (refs openwrt/openwrt#10024)
breakings
pushed a commit
to breakings/packages
that referenced
this pull request
Jul 30, 2022
Since the OpenWrt's stub libiconv implementation is now gone, we can build against musl's internal one or the external libiconv implementation. This needs minor adjustements in the makefile to allow PHPs build to choose the right path when cross-compiling. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Beginner-Go
pushed a commit
to coolsnowwolf/packages
that referenced
this pull request
Jul 30, 2022
* php8: fixup libiconv usage (refs openwrt/openwrt#10024) Since the OpenWrt's stub libiconv implementation is now gone, we can build against musl's internal one or the external libiconv implementation. This needs minor adjustements in the makefile to allow PHPs build to choose the right path when cross-compiling. Signed-off-by: Michael Heimpold <mhei@heimpold.de> * php8: update to 8.1.8 This fixes: - CVE-2022-31627 Signed-off-by: Michael Heimpold <mhei@heimpold.de> Co-authored-by: Michael Heimpold <mhei@heimpold.de>
stokito
pushed a commit
to stokito/packages
that referenced
this pull request
Dec 6, 2022
Since the OpenWrt's stub libiconv implementation is now gone, we can build against musl's internal one or the external libiconv implementation. This needs minor adjustements in the makefile to allow PHPs build to choose the right path when cross-compiling. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
ineedfat
pushed a commit
to ineedfat/rockchip_rk3568_openwrt_packages
that referenced
this pull request
Jun 7, 2024
* php8: fixup libiconv usage (refs openwrt/openwrt#10024) Since the OpenWrt's stub libiconv implementation is now gone, we can build against musl's internal one or the external libiconv implementation. This needs minor adjustements in the makefile to allow PHPs build to choose the right path when cross-compiling. Signed-off-by: Michael Heimpold <mhei@heimpold.de> * php8: update to 8.1.8 This fixes: - CVE-2022-31627 Signed-off-by: Michael Heimpold <mhei@heimpold.de> Co-authored-by: Michael Heimpold <mhei@heimpold.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting as draft until I make sure all packages compile.