Fix issue about 'find_unused_parameters' when DDP training. #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annotation slim
agentasteriski
added a commit
to agentasteriski/DiffSinger
that referenced
this pull request
Apr 16, 2025
…training. (openvpi#244)" This reverts commit 76620b3.
agentasteriski
added a commit
to agentasteriski/DiffSinger
that referenced
this pull request
Apr 16, 2025
… training. (openvpi#244)" This reverts commit 1e22cfd.
agentasteriski
added a commit
to agentasteriski/DiffSinger
that referenced
this pull request
Apr 16, 2025
…training. (openvpi#244)" This reverts commit 76620b3.
yxlllc
pushed a commit
that referenced
this pull request
Aug 16, 2025
#244) * Fix issue about 'find_unused_parameters' when DDP training. * annotation * slim * Fix issue about 'find_unused_parameters' when DDP training. annotation slim * Update rotary_embedding_torch.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当多卡训练时（DDP），会提示需要设定
find_unused_parameters=True，这是因为DDP下要求所有可学习参数均在前向过程中但当设定
find_unused_parameters=True后，会提示不需要find_unused_parameters=True这是因为使用的RoPE实现包含的cache机制，当
should_cache时，self.freqs并不包含在前向过程中