Skip to content

[LPT] Assign + ReadValue transformation#8690

Merged
eshoguli merged 3 commits intoopenvinotoolkit:masterfrom
vzinovie:vz/lpt/assign_transformation
Dec 27, 2021
Merged

[LPT] Assign + ReadValue transformation#8690
eshoguli merged 3 commits intoopenvinotoolkit:masterfrom
vzinovie:vz/lpt/assign_transformation

Conversation

@vzinovie
Copy link
Copy Markdown
Contributor

@vzinovie vzinovie commented Nov 18, 2021

Details:

  • Assign + ReadValue transformation for GNA pipeline

Tickets:

  • 67516

@vzinovie vzinovie requested review from a team November 18, 2021 16:29
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Nov 18, 2021
@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch from 925585d to b776dd8 Compare November 18, 2021 17:12
itikhono
itikhono reviewed Dec 2, 2021
View reviewed changes
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp Outdated
itikhono
itikhono reviewed Dec 2, 2021
View reviewed changes
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp Outdated
itikhono
itikhono reviewed Dec 2, 2021
View reviewed changes
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp Outdated
eshoguli
eshoguli reviewed Dec 8, 2021
View reviewed changes
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp Outdated
Comment thread ...hared_tests_instances/low_precision_transformations/assign_and_read_value_transformation.cpp Outdated
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp Outdated
Comment thread inference-engine/src/low_precision_transformations/src/fake_quantize_dequantization.cpp
Comment thread inference-engine/src/low_precision_transformations/src/assign_and_read_value.cpp
eshoguli
eshoguli reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown

@eshoguli eshoguli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is shared plugin test instantiation for GPU?

Comment thread inference-engine/src/low_precision_transformations/src/network_helper.cpp Outdated
Comment thread inference-engine/src/low_precision_transformations/src/network_helper.cpp Outdated
Comment thread ...ence-engine/tests/ngraph_helpers/lpt_ngraph_functions/src/assign_and_read_value_function.cpp Outdated
Comment thread ...ence-engine/tests/ngraph_helpers/lpt_ngraph_functions/src/assign_and_read_value_function.cpp Outdated
Comment thread ...ence-engine/tests/ngraph_helpers/lpt_ngraph_functions/src/assign_and_read_value_function.cpp Outdated
Comment thread ...ne/tests/functional/inference_engine/lp_transformations/simple_low_precision_transformer.hpp Outdated
@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch from b776dd8 to be40d60 Compare December 16, 2021 13:05
@vzinovie vzinovie requested a review from a team December 16, 2021 13:05
@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch from be40d60 to 535e268 Compare December 16, 2021 13:07
@vzinovie
Copy link
Copy Markdown
Contributor Author

vzinovie commented Dec 16, 2021 •
edited
Loading

@itikhono @eshoguli Thanks for your comments! I applied them, could you please review or approve?

@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch from 535e268 to 4aff232 Compare December 16, 2021 13:16
@vzinovie
Copy link
Copy Markdown
Contributor Author

vzinovie commented Dec 16, 2021

Where is shared plugin test instantiation for GPU?

@eshoguli I added test for GPU.

itikhono
itikhono approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@itikhono itikhono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch 2 times, most recently from 7eae7ad to efff821 Compare December 20, 2021 11:53
@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch from efff821 to 83c8438 Compare December 20, 2021 12:01
eshoguli
eshoguli approved these changes Dec 20, 2021
View reviewed changes
Copy link
Copy Markdown

@eshoguli eshoguli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch 2 times, most recently from a201c40 to 852c2d4 Compare December 23, 2021 10:54
@eshoguli eshoguli enabled auto-merge (squash) December 23, 2021 11:26
@vzinovie vzinovie force-pushed the vz/lpt/assign_transformation branch 2 times, most recently from 75fb044 to 19fd8bb Compare December 27, 2021 12:11
@eshoguli eshoguli merged commit c5824b8 into openvinotoolkit:master Dec 27, 2021
azhogov pushed a commit that referenced this pull request Dec 27, 2021
Revert "[LPT] Assign + ReadValue transformation (#8690)"
1a693d3 
This reverts commit c5824b8.
@azhogov azhogov mentioned this pull request Dec 27, 2021
Merged
azhogov pushed a commit that referenced this pull request Dec 27, 2021
Revert "[LPT] Assign + ReadValue transformation (#8690)" (#9457)
d51f337 
This reverts commit c5824b8.
azhogov pushed a commit that referenced this pull request Dec 27, 2021
Revert "Revert "[LPT] Assign + ReadValue transformation (#8690)" (#9457…
43613a4 
…)"

This reverts commit d51f337.
azhogov pushed a commit that referenced this pull request Dec 27, 2021
Revert "Revert "[LPT] Assign + ReadValue transformation (#8690)" (#9457…
32bc784 
…)" (#9460)

This reverts commit d51f337.
vzinovie added a commit to vzinovie/openvino that referenced this pull request Dec 29, 2021
@vzinovie
Revert "[LPT] Assign + ReadValue transformation (openvinotoolkit#8690)"
04472e3 
This reverts commit c5824b8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-Golubev v-Golubev Awaiting requested review from v-Golubev

2 more reviewers

@itikhono itikhono itikhono approved these changes

@eshoguli eshoguli eshoguli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vzinovie @itikhono @eshoguli @openvino-pushbot