Skip to content

[GNA] More precized calculation of Log pwl and pwl with sf < 1#7884

Merged
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
elilobanova:slope_small_sf
Oct 13, 2021
Merged

[GNA] More precized calculation of Log pwl and pwl with sf < 1#7884
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
elilobanova:slope_small_sf

Conversation

@elilobanova
Copy link
Copy Markdown
Contributor

Details:

  • Improved the algorithm of scale factors adjustment to decrease pwl slope quantization error

Tickets:

67349

@elilobanova elilobanova requested review from a team, dmitriikhurtin, mryzhov and nkogteva October 7, 2021 09:35
@openvino-pushbot openvino-pushbot added category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common labels Oct 7, 2021
@nkogteva
Copy link
Copy Markdown
Contributor

nkogteva commented Oct 7, 2021

I'm wondering whether this PR can help to enable any disabled activation tests or not?

@elilobanova
Copy link
Copy Markdown
Contributor Author

I'm wondering whether this PR can help to enable any disabled activation tests or not?

this PR doesn't enable activation tests, I think these tests rather depends on number of segments for PWL, probably we need to use configuration option PWL_ME or change the plugin behavior to chose the biggest possible number of segments without this option,
also more accurate calculation of scale factors for activations is provided with using POT, so probably pre-processing of GNA tests with POT can also help to enable these tests

@dorloff dorloff merged commit b746c73 into openvinotoolkit:master Oct 13, 2021
elilobanova added a commit to elilobanova/openvino that referenced this pull request Oct 13, 2021
…inotoolkit#7884)

* [GNA] More precized calculation of Log pwl and pwl with sf < 1

* [GNA] Added tests

* [GNA] Types correction

* [GNA] Added comment for absolute threshold calculation in the test
azhogov pushed a commit that referenced this pull request Oct 14, 2021
#7982)

* [GNA] More precized calculation of Log pwl and pwl with sf < 1

* [GNA] Added tests

* [GNA] Types correction

* [GNA] Added comment for absolute threshold calculation in the test
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
…inotoolkit#7884)

* [GNA] More precized calculation of Log pwl and pwl with sf < 1

* [GNA] Added tests

* [GNA] Types correction

* [GNA] Added comment for absolute threshold calculation in the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants