Skip to content

[GNA] Fixes for convolution handling#7861

Merged
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
elilobanova:input_orient_error
Oct 13, 2021
Merged

[GNA] Fixes for convolution handling#7861
dorloff merged 4 commits intoopenvinotoolkit:masterfrom
elilobanova:input_orient_error

Conversation

@elilobanova
Copy link
Copy Markdown
Contributor

@elilobanova elilobanova commented Oct 6, 2021 •
edited
Loading

Details:

  • Support a case when convolution output has only one dimension > 1, in this case trailing transpose will be replaced by a reshape
  • Removed orientation check for layers connected to input. It'd have a sense if Convolution first input dimension will be > 1 (since only Convolution is a layer with deinterleaved orientation) but such cases are not supported by GNA.
  • Fixed InsertTransposeAfterConvOrPool transformation for a case when convolution or pooling output has only one dimension > 1
  • Fixed a problem with ConvolutionFilter sizes
  • Added tests for these cases
  • delayed_copy_layer test is fixed and added to CI verification (it seems it was not updated during some changes in tests infrastructure and is failed without this update)

Tickets:

66334

@elilobanova elilobanova requested review from a team, dmitriikhurtin, mryzhov and nkogteva October 6, 2021 09:22
@openvino-pushbot openvino-pushbot added category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common labels Oct 6, 2021
@elilobanova elilobanova requested a review from kbruniec October 7, 2021 10:49
nkogteva
nkogteva reviewed Oct 7, 2021
View reviewed changes
@nkogteva nkogteva mentioned this pull request Oct 7, 2021
Closed
@elilobanova elilobanova force-pushed the input_orient_error branch 3 times, most recently from a7e2e6f to 9fccf82 Compare October 11, 2021 06:42
@dorloff dorloff merged commit 917a292 into openvinotoolkit:master Oct 13, 2021
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@elilobanova @dood-apo
[GNA] Fixes for convolution handling (openvinotoolkit#7861)
1f09cdc 
* [GNA] Fixed errors with convolution handling

* [GNA] Tests added

* [GNA] Fixed the problem with Convolution Filter

* [GNA] Allow scale factors near 0, comments apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mryzhov mryzhov Awaiting requested review from mryzhov

@dmitriikhurtin dmitriikhurtin Awaiting requested review from dmitriikhurtin

2 more reviewers

@nkogteva nkogteva nkogteva approved these changes

@kbruniec kbruniec kbruniec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elilobanova @nkogteva @kbruniec @openvino-pushbot @dorloff