Skip to content

[GPU] Implementations refactoring#6603

Merged
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:masterfrom
vladimir-paramuzov:improve_impls_registration
Jul 15, 2021
Merged

[GPU] Implementations refactoring#6603
vladimir-paramuzov merged 1 commit intoopenvinotoolkit:masterfrom
vladimir-paramuzov:improve_impls_registration

Conversation

@vladimir-paramuzov
Copy link
Copy Markdown

@vladimir-paramuzov vladimir-paramuzov commented Jul 12, 2021

Details:

  • Refactored and simplified registration of factory methods for implementation. Now key consists of format+precision pair and function ref + impl type are passed once as separate argument
    Introduced impl_types enum.
  • All primitive implementations were moved to separate impls folder.
  • Implementations were grouped by type: common, cpu, ocl
  • inner namespace for implementations was replaced from gpu to impl type specific namespace (ocl, cpu, etc)
  • Enabled impl forcing mechanism
  • any impl type is used by default if no forced impl is specified
  • Extracted from [GPU] Added onednn dependency. #6564

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Jul 12, 2021
@vladimir-paramuzov vladimir-paramuzov added this to the 2022.1 milestone Jul 12, 2021
@vladimir-paramuzov vladimir-paramuzov marked this pull request as ready for review July 12, 2021 11:16
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners July 12, 2021 11:16
@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Jul 12, 2021
Merged
@vladimir-paramuzov vladimir-paramuzov force-pushed the improve_impls_registration branch 2 times, most recently from 32355ef to 560f60b Compare July 13, 2021 05:00
@vladimir-paramuzov vladimir-paramuzov mentioned this pull request Jul 13, 2021
Merged
isanghao
isanghao approved these changes Jul 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@isanghao isanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is huge..

@vladimir-paramuzov vladimir-paramuzov force-pushed the improve_impls_registration branch from 560f60b to fc412e2 Compare July 14, 2021 11:42
yeonbok
yeonbok reviewed Jul 15, 2021
View reviewed changes
@yeonbok
Copy link
Copy Markdown
Contributor

yeonbok commented Jul 15, 2021

Left a minor comments and LGTM.

@vladimir-paramuzov vladimir-paramuzov force-pushed the improve_impls_registration branch from fc412e2 to e7ef801 Compare July 15, 2021 05:36
@vladimir-paramuzov vladimir-paramuzov merged commit 788e767 into openvinotoolkit:master Jul 15, 2021
@vladimir-paramuzov vladimir-paramuzov deleted the improve_impls_registration branch July 15, 2021 09:05
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
[GPU] Impls refactoring (openvinotoolkit#6603)
b8f45e8
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@andrei-cv
[GPU] Impls refactoring (openvinotoolkit#6603)
b1de869
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@akuporos
[GPU] Impls refactoring (openvinotoolkit#6603)
f6f5876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeonbok yeonbok yeonbok left review comments

@isanghao isanghao isanghao approved these changes

Assignees

No one assigned

Labels

category: GPU OpenVINO GPU plugin

Projects

None yet

Milestone

2022.1

Development

Successfully merging this pull request may close these issues.

3 participants

@vladimir-paramuzov @yeonbok @isanghao