Static protobuf for FEs#6588
Merged
ilyachur merged 28 commits intoopenvinotoolkit:masterfrom Jul 16, 2021
Merged
Conversation
added 7 commits
July 8, 2021 10:50
2290b05 to
7c6a4e2
Compare
91ece81 to
43a490a
Compare
56761d8 to
4c968fe
Compare
tsocha
approved these changes
Jul 15, 2021
| # | ||
|
|
||
| set(TARGET_NAME "onnx_editor") | ||
| #set(TARGET_NAME "onnx_editor") |
Contributor
There was a problem hiding this comment.
Since this file is not needed, could you remove it?
nosovmik
reviewed
Jul 15, 2021
| { | ||
| public: | ||
| EdgeMapper() = default; | ||
| ONNX_IMPORTER_API EdgeMapper() = default; |
Contributor
There was a problem hiding this comment.
Why exporting per method is used instead of standard 'class ONNX_IMPORTER_API EdgeMapper' (this way is used in other places of ngraph-core)?
Contributor
Author
There was a problem hiding this comment.
I don't want to export ctor with protobufs entities
nosovmik
approved these changes
Jul 15, 2021
| file(GLOB_RECURSE LIBRARY_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/src/*.hpp) | ||
| file(GLOB_RECURSE LIBRARY_PUBLIC_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/include/*.hpp) | ||
|
|
||
| file(GLOB_RECURSE EDITOR_LIBRARY_SRC ${CMAKE_CURRENT_SOURCE_DIR}/../onnx_editor/src/*.cpp) |
Contributor
There was a problem hiding this comment.
should folder structure be reorganized in future? like having only 'onnx' folder instead of onnx_import, onnx_editor, onnx_common
Contributor
Author
There was a problem hiding this comment.
yes, editor and importer will be somehow merged in a separate change
Currently, we want to focus on protobuf related questions
ilyachur
approved these changes
Jul 16, 2021
Closed
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* protobuf static + mixed editor and importer * merged onnx common * remove ngraph_test_util to onnx_importer and onnx * styles applied * Revert "remove ngraph_test_util to onnx_importer and onnx". * test ngraph_test_util dependencies * Fixed static protobuf * Next * Fixes * Fixed cross-compilation * Don't export / install onnx_proto * Fixed Windows * Fixed opencl headers * Fix * Added exclude-all for exe as well * Fixed code style * Try without LTO * LTO off only for onnx importer Co-authored-by: mbencer <mateusz.bencer@intel.com>
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Aug 30, 2021
* protobuf static + mixed editor and importer * merged onnx common * remove ngraph_test_util to onnx_importer and onnx * styles applied * Revert "remove ngraph_test_util to onnx_importer and onnx". * test ngraph_test_util dependencies * Fixed static protobuf * Next * Fixes * Fixed cross-compilation * Don't export / install onnx_proto * Fixed Windows * Fixed opencl headers * Fix * Added exclude-all for exe as well * Fixed code style * Try without LTO * LTO off only for onnx importer Co-authored-by: mbencer <mateusz.bencer@intel.com>
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
* protobuf static + mixed editor and importer * merged onnx common * remove ngraph_test_util to onnx_importer and onnx * styles applied * Revert "remove ngraph_test_util to onnx_importer and onnx". * test ngraph_test_util dependencies * Fixed static protobuf * Next * Fixes * Fixed cross-compilation * Don't export / install onnx_proto * Fixed Windows * Fixed opencl headers * Fix * Added exclude-all for exe as well * Fixed code style * Try without LTO * LTO off only for onnx importer Co-authored-by: mbencer <mateusz.bencer@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: