Revise Round operation reference implementation#6287
Merged
ilyachur merged 2 commits intoopenvinotoolkit:masterfrom Jun 22, 2021
Merged
Revise Round operation reference implementation#6287ilyachur merged 2 commits intoopenvinotoolkit:masterfrom
ilyachur merged 2 commits intoopenvinotoolkit:masterfrom
Conversation
improve the input type error check add attribute test case Signed-off-by: Hu, Yuan2 <yuan2.hu@intel.com>
Signed-off-by: Hu, Yuan2 <yuan2.hu@intel.com>
ilyachur
approved these changes
Jun 22, 2021
tiger100256-hu
commented
Jun 22, 2021
| { | ||
| NodeBuilder::get_ops().register_factory<opset5::Round>(); | ||
| auto data = make_shared<op::Parameter>(element::f32, Shape{200}); | ||
| auto round = make_shared<opset5::Round>(data, opset5::Round::RoundMode::HALF_TO_EVEN); |
Contributor
Author
There was a problem hiding this comment.
@ilyachur very sorry, I found there is a mistake here, it should be make_sharedopset5::Round(data, mode); but the code have be merged into master, do I need to create a new PR for it ?
3 tasks
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* Revise OP Round improve the input type error check add attribute test case Signed-off-by: Hu, Yuan2 <yuan2.hu@intel.com> * fix clang code style issue Signed-off-by: Hu, Yuan2 <yuan2.hu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve the input type error check
add attribute test case
Signed-off-by: Hu, Yuan2 yuan2.hu@intel.com
Details:
Tickets: